QA Refresh: Upgrade Psalm, Add PHPStan + composer-require-checker

[gsteel]

• Upgrade Psalm to latest, fix or supress issues
  • Everything is now either final in test or @final in src
• Remove v3 of psr/container from dependencies (It doesn't exist)
• Add composer-require-checker to local tools and to CI
• Fix missing, un-declared deps
• Add a Makefile for running QA and building docs locally
• Add PHPStan on max level with a small baseline and fix a load of minor issues

[gsteel]

Testing out a stricter set of QA tooling to see how we go.

Adding PHPStan to existing pipelines will help migration away from Psalm if that becomes necessary - and running both is not a bad idea anyhow!

[froschdesign]

• Add a Makefile for running QA and building docs locally

Copying the file to every repository does not seem very future-proof to me. 🤷🏻‍♂️

[gsteel]

Copying the file to every repository does not seem very future-proof to me

Got any ideas for automating Makefile deployment to all the repos?

OTOH, It's plausible that Makefiles might diverge in different repos… Do you see it as a problem to use make? I personally much prefer it to composer scripts and things like building docker images etc can't really be done in composer.

[froschdesign]

Do you see it as a problem to use make?

No, of course not but in copy and paste.

[Ocramius]

Make itself isn't really reuse-friendly.

We could make a reusable nix derivation containing a make entry-point perhaps? That would be supported by renovate.

[gsteel]

We could make a reusable nix derivation containing a make entry-point perhaps? That would be supported by renovate.

OK, now you've lost me 😂

[gsteel]

@Ocramius
Could adding flake.nix and flake.lock to the root of repos automate things like .gitattributes dot files, installing standalone tools in sub-directories etc?

[Ocramius]

Roughly, yes: I'm very new to it as well though 😁