Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop laminas/laminas-zendframework-bridge and zendframework/* compatibility #11

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

PowerKiKi
Copy link
Contributor

Q A
Documentation no
Bugfix yes
BC Break no
New Feature no
RFC no
QA no

Description

Increase performance by removing a compatibility layer while not introducing breaking changes.

This follow the process described in details in:

https://github.com/laminas/technical-steering-committee/blob/main/meetings/minutes/2021-08-02-TSC-Minutes.md#remove-laminaslaminas-zendframework-bridge-dependency-from-our-packages

Copy link
Member

@internalsystemerror internalsystemerror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"laminas/laminas-zendframework-bridge" needs to be removed from the "require" section.

Copy link
Member

@internalsystemerror internalsystemerror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also it should conflict with ALL versions of zend, i.e. "*"

@PowerKiKi
Copy link
Contributor Author

Thank you for the review. I updated according to your comments.

Copy link
Member

@internalsystemerror internalsystemerror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the workflow passes, LGTM

Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A rebase is needed: let's defer to 3.3.0

…patibility

Increase performance by removing a compatibility layer while **not** introducing breaking changes.

This follow the process described in details in:

https://github.com/laminas/technical-steering-committee/blob/main/meetings/minutes/2021-08-02-TSC-Minutes.md#remove-laminaslaminas-zendframework-bridge-dependency-from-our-packages
Signed-off-by: Adrien Crivelli <[email protected]>
@PowerKiKi PowerKiKi changed the base branch from 3.2.x to 3.3.x December 6, 2021 04:47
@PowerKiKi
Copy link
Contributor Author

rebased, and PR targeting mezzio:3.3.x

@Ocramius Ocramius added this to the 3.3.0 milestone Dec 6, 2021
@Ocramius Ocramius self-assigned this Dec 6, 2021
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @PowerKiKi!

@Ocramius Ocramius merged commit a9e7352 into mezzio:3.3.x Dec 6, 2021
@PowerKiKi PowerKiKi deleted the drop-bridge branch December 6, 2021 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants