-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop laminas/laminas-zendframework-bridge
and zendframework/*
compatibility
#11
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"laminas/laminas-zendframework-bridge"
needs to be removed from the "require" section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also it should conflict with ALL versions of zend, i.e. "*"
ce88505
to
6bbe3d4
Compare
Thank you for the review. I updated according to your comments. |
6bbe3d4
to
1bf9ee5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming the workflow passes, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A rebase is needed: let's defer to 3.3.0
…patibility Increase performance by removing a compatibility layer while **not** introducing breaking changes. This follow the process described in details in: https://github.com/laminas/technical-steering-committee/blob/main/meetings/minutes/2021-08-02-TSC-Minutes.md#remove-laminaslaminas-zendframework-bridge-dependency-from-our-packages Signed-off-by: Adrien Crivelli <[email protected]>
1bf9ee5
to
1ae9b04
Compare
rebased, and PR targeting mezzio:3.3.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @PowerKiKi!
Description
Increase performance by removing a compatibility layer while not introducing breaking changes.
This follow the process described in details in:
https://github.com/laminas/technical-steering-committee/blob/main/meetings/minutes/2021-08-02-TSC-Minutes.md#remove-laminaslaminas-zendframework-bridge-dependency-from-our-packages