feat: add metrics-exporter-otel crate #595
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… boundaries Add support for configuring custom histogram bucket boundaries in the OpenTelemetry exporter. This allows users to define specific bucket boundaries for individual metrics, enabling better histogram resolution tailored to expected value distributions. - Add histogram_bounds HashMap shared between recorder and storage via Arc<RwLock<>> - Implement set_histogram_bounds() method to configure boundaries before histogram creation - Apply custom boundaries when creating histograms in OtelMetricStorage - Add comprehensive test coverage for custom histogram bounds functionality - Fix integration tests to use InMemoryMetricExporter with proper assertions 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Add detailed documentation following patterns from other metrics exporters: - Module-level overview with features, usage examples, and performance notes - Comprehensive API documentation for OpenTelemetryRecorder - Detailed method docs with examples and behavioral constraints - Internal type documentation for MetricDescription and MetricMetadata - Missing docs enforcement and broken link detection 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Add basic usage example - Add custom histogram bounds example - Add OTLP exporter example - Significantly reduce documentation verbosity - Delegate unit conversion details to Unit documentation - Clarify that descriptions/bounds only apply to metrics created after they are set 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
palindrom615
changed the title
|
found someone already took the name |
Found the name already took by someone https://crates.io/crates/metrics-exporter-opentelemetry
|
@tobz @LucioFranco Although the size of the PR is quite non-trival, could you please take a look? |
I can appreciate the desire to get this merged, but reviewing brand new crate additions will likely take some time (3-4 weeks) since I'm fairly busy and don't spend a ton of time reviewing PRs in the repository. If you want to start using the crate sooner, then it might be worth creating your own repository for it and publishing it to crates.io. It's always possible to transfer ownership later on if we think it would be better suited to live in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Features
Test Plan
Examples
Closes #275
🤖 Generated with Claude Code