-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: added missing german stations #483
chore: added missing german stations #483
Conversation
@clampr I found this pull request after realizing, that DWD stations are missing in the Meteostat system. Has this pull request been denied or only been forgotten? What would it take to merge this pull request and close the DWD station gap in the Meteostat system? |
First, I want to appologize for taking so much time to review this PR. Great job @SiddharthKhatsuriya 🙂 I added the ISO codes for the regions (Bundesländer) and the time zone. Also fixed the pipeline errors. @peterhaufler could you be so kind and review the changes? I'd like to know if it roughly matches the discrepancy that you guys have identified. Obviously, we're still missing the stations that have been flagged as duplicates. Will create a follow-up issue for these stations. |
@clampr thanks for taking care for this pull request :) On my side, I just realised, that for one of our weather insurance contracts, there was a much nearer weather station available "Bochum" to the insured location, than the one provided by Meteostat. I found that station in this pull request (id LH10Y). |
Follow-up issue created (#489). |
I might be a little too late but is the duplicate station situation still persists? Its funny I didn't see Its closed and went straight to the problem. I did find out that Burgbernheim (ID: 00801) is a duplicate of Illesheim (ID: 10752). They are the closure cities and one serves them both(I guess). and i thinkI might be the clown here but reply would be appreciated. |
Added missing German weather station from DWD database.
Note: when comparing the DWD databse and meteostat there were 520+ stations missing, but accordign to the
find_duplicates
logic ~180 of these missing stations are not getting added because they are probably too close to each other. I have addedscripts\germany\duplicate_stations_reported.json
which shows all the stations that are considered duplicate.