Improved configuration mechanism for testing #1352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the ConfigLoader plugin for Catalyst mostly matches the behavior of our Config module, it can have some differences. In particular, it may not properly load the testing config.
It can be useful to modify the testing config, such as to point to an alternate Elasticsearch server. When loading the testing config using a modified config suffix, it will merge the data with the main config. But this also prevents loading a local testing config. Instead, we can use a custom config file name, and still allow a _local suffix. Copy the extra config options from the main config to the test config, since it will no longer be merging them.
haarg
force-pushed
the
haarg/config-in-cat
branch
from
b79a6d2 to
38853d4
Compare
mickeyn
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the configuration used by Catalyst is the same as what is used by the scripts and everything else. And it allows a
metacpan_server_testing_localconfig file to be used.