Repository navigation
Fix security issues - #1378
Open
bpander wants to merge 2 commits into
Open
Fix security issues#1378bpander wants to merge 2 commits into
bpander wants to merge 2 commits into
Conversation
|
Commit 231822c is live at https://docs-pr-1378-metaboat.vercel.app
Deployed to Vercel via GitHub Actions |
bpander
force-pushed
the
fix-code-scanning-issues
branch
from
October 8, 2026 17:52
9a3f820 to
c016525
Compare
bpander
force-pushed
the
fix-code-scanning-issues
branch
from
October 8, 2026 18:21
c016525 to
658af28
Compare
bpander
marked this pull request as ready for review
October 8, 2026 18:30
losrebellos
requested changes
Oct 9, 2026
| referrerUrl = document.referrer ? new URL(document.referrer) : null; | ||
| } catch (e) { | ||
| // Ignore invalid referrer URLs | ||
| referrerUrl = null; |
Contributor
There was a problem hiding this comment.
Unnecessary since it repeats the default value...
| referrerUrl = document.referrer ? new URL(document.referrer) : null; | ||
| } catch (e) { | ||
| // Ignore invalid referrer URLs | ||
| referrerUrl = null; |
Contributor
There was a problem hiding this comment.
Unnecessary since it repeats the default value...
| } | ||
|
|
||
| // custom referrer (only for metabase.com) | ||
| var referrerUrl = null; |
Contributor
There was a problem hiding this comment.
Since everything is named with the Anon suffix, should we have the same for that? Meaning referrerUrlAnon... it might create a "collision" with the other referrerUrl ;)
…or clarity and prevent collision
bpander
force-pushed
the
fix-code-scanning-issues
branch
from
October 9, 2026 13:21
ef1b3f0 to
231822c
Compare
Contributor
Author
|
@losrebellos Thanks for the feedback! Addressed the comments in 231822c. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix security issues flagged in https://github.com/metabase/metabase.github.io/pull/6651/checks?check_run_id=113024868999
They're also flagged in this repo: https://github.com/metabase/docs.metabase.github.io/security/code-scanning
Fixing them now so they don't get flagged in the docs->monorepo migration and because they're easy and we should do them anyway.