Repository navigation
Conversation
|
The deployments were removed when this pull request closed. Reopening it deploys again at the same address. |
losrebellos
requested changes
Oct 8, 2026
| @@ -0,0 +1 @@ | |||
| /Users/gabrielmoreno/Developer/metabase/docs.metabase.github.io/_docs No newline at end of file | |||
Contributor
There was a problem hiding this comment.
Weird... should it be /_docs instead?
Contributor
Author
There was a problem hiding this comment.
I believe this might be an artifact and shouldn't have been tracked in the first place, removed it! Also simplified the PR a lot
losrebellos
approved these changes
Oct 9, 2026
Comment on lines
+239
to
+242
| display: box; | ||
| display: flex; | ||
| display: flexbox; | ||
| display: flex; |
Contributor
There was a problem hiding this comment.
Should we just have display: flex;?
losrebellos
reviewed
Oct 9, 2026
Contributor
There was a problem hiding this comment.
Could it be merged with his best friend at line 140?
gantoreno
deleted the
gro-905-remove-unused-docs-css-after-retiring-shared-chrome
branch
October 9, 2026 14:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes GRO-905