Skip to content

Fix failing tests #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix failing tests #793

wants to merge 1 commit into from

Conversation

@evgri243
Copy link
Contributor

  • Increased tolerance for gradient comparison test from 1e-7 to 2e-7 in conv2d_test.py.
  • Added GRU validator imports in validators/__init__.py.
  • Disabled downloading of pretrained weights in PrivacyEngine test.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs change / refactoring / dependency upgrade

Motivation and Context / Related issue

I experience a few failing tests in local setup, this minor changes seems to fix them.

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document and completed the CLA (see CONTRIBUTING).
  • All tests passed, and additional code has been covered with new tests.

@evgri243
Fix failing tests
7446150 
- Increased tolerance for gradient comparison test from `1e-7` to `2e-7` in `conv2d_test.py`.
- Added GRU validator imports in `validators/__init__.py`.
- Disabled downloading of pretrained weights in PrivacyEngine test.
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 20, 2025
@meta-codesync
Copy link

meta-codesync bot commented Oct 20, 2025

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D85085351. (Because this pull request was imported automatically, there will not be any future comments.)

@iden-kalemaj iden-kalemaj self-assigned this Oct 24, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 18664590775

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 80.408%
Totals Coverage Status
Change from base Build 18737255617: 0.003%
Covered Lines: 5635
Relevant Lines: 7008
💛 - Coveralls

@iden-kalemaj
Copy link
Contributor

Thank you for these changes! These look good.

iden-kalemaj
iden-kalemaj approved these changes Oct 24, 2025
View reviewed changes
Copy link
Contributor

@iden-kalemaj iden-kalemaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@meta-codesync meta-codesync bot closed this in 7dd02da Oct 24, 2025
@meta-codesync
Copy link

meta-codesync bot commented Oct 24, 2025

This pull request has been merged in 7dd02da.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iden-kalemaj iden-kalemaj iden-kalemaj approved these changes

Assignees

@iden-kalemaj iden-kalemaj

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@evgri243 @coveralls @iden-kalemaj @facebook-github-bot