Structuring arguments in gen_candidates_torch #3019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3019 +/- ##
=======================================
Coverage 99.99% 99.99%
=======================================
Files 219 219
Lines 20881 20884 +3
=======================================
+ Hits 20880 20883 +3
Misses 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hvarfner
pushed a commit
to hvarfner/botorch
that referenced
this pull request
Sep 19, 2025
Summary: Structuring the optimizer and stopping_criterion arguments in gen_candidates_torch. Fixes meta-pytorch#2994. Differential Revision: D82839737
hvarfner
force-pushed
the
export-D82839737
branch
from
5abf69e to
90e16b6
Compare
Contributor
hvarfner
force-pushed
the
export-D82839737
branch
from
90e16b6 to
7bf4510
Compare
hvarfner
pushed a commit
to hvarfner/botorch
that referenced
this pull request
Nov 14, 2025
Summary: X-link: meta-pytorch#3019 Structuring the optimizer and stopping_criterion arguments in gen_candidates_torch. Fixes meta-pytorch#2994. Differential Revision: D82839737
hvarfner
pushed a commit
to hvarfner/botorch
that referenced
this pull request
Nov 14, 2025
Summary: X-link: meta-pytorch#3019 Structuring the optimizer and stopping_criterion arguments in gen_candidates_torch. Fixes meta-pytorch#2994. Differential Revision: D82839737
hvarfner
force-pushed
the
export-D82839737
branch
from
7bf4510 to
6601e65
Compare
hvarfner
pushed a commit
to hvarfner/botorch
that referenced
this pull request
Nov 14, 2025
Summary: X-link: meta-pytorch#3019 Structuring the optimizer and stopping_criterion arguments in gen_candidates_torch. Fixes meta-pytorch#2994. Reviewed By: sdaulton Differential Revision: D82839737
hvarfner
force-pushed
the
export-D82839737
branch
from
6601e65 to
1697317
Compare
Summary: X-link: meta-pytorch#3019 Structuring the optimizer and stopping_criterion arguments in gen_candidates_torch. Fixes meta-pytorch#2994. Reviewed By: sdaulton Differential Revision: D82839737
hvarfner
force-pushed
the
export-D82839737
branch
from
1697317 to
e009de3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Structuring the optimizer and stopping_criterion arguments in gen_candidates_torch.
Fixes #2994.
Differential Revision: D82839737