Add more annotation functions #171
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginnyTheCat
reviewed
Sep 7, 2025
|
|
||
| impl std::error::Error for OutOfRange {} | ||
|
|
||
| impl TryFrom<pdf_intent> for Intent { |
There was a problem hiding this comment.
Could this file be simplified by using the from_enum! macro like here?
There was a problem hiding this comment.
Basically, yes, but it does things slightly differently from the from_enum macro. However, I've now filed #172 to fix some issues that I was seeing with that macro, and once those changes are merged in, I can switch this usage over.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just what the title says, more support for annotation functions