-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove conda #294
Remove conda #294
Conversation
Update build-docs workflow Add cache-dependencies workflow Update cleanup-firebase workflow Update ci workflow Update analyze workflow Update analyze workflow
110ea0e
to
5c690d3
Compare
1. Download the installer | ||
|
||
```bash | ||
curl -sSLO https://pdm.fming.dev/install-pdm.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my case, this command didn't trigger the installation, I used the one from the instruction (curl -sSL https://pdm-project.org/install-pdm.py | python3 -
) instead, and it worked smoothly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This command just downloads the installer. Step 3 in the instructions (python install-pdm.py
) runs the downloaded installer and installs pdm. Thanks for checking this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to follow the instructions to install pyenv and pdm, successfully create a virtual environment, and run a packing. Thank you for making these updates, they'll be a great help for our future development!
* Update makefile to move cleanup * Specify base python in tox.ini
We are ready to merge and release cellPACK 1.1.1!! Just re-requested review for some minor changes. Let me know if we're good to go ahead :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for all the hard work! I imagine you ran into plenty of unexpected issues during the transition to the new environment. Just curious: why did we add pdm run
to each command? I tested without it and seemed to work fine.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the slow response, I was also able to set it up locally and run!
This version includes performance improvements, bug fixes, and installation updates
6cac614
to
f19f71d
Compare
Problem
Closes #293
Solution
Changed the dependency management platform from
conda
topyenv
+pdm
with @rugeli
Type of change
Change summary:
setup.py
,setup.cfg
,tox.ini
and consolidate all configurations intopyproject.toml
pdm.lock
to pin exact versions of dependenciespdm
for setup with cacheSteps to Verify:
docs/INSTALL.md
to installcellPACK
usingpyenv
+pdm
.pdm run pytest
pack -r cellpack/tests/recipes/v2/test_spheres.json
Many thanks to Philip Garrison for laying the groundwork for this transition!