libgrapheme: use find_program instead of relying on shebang #2303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently during testing it slipped through that meson does not apply file permissions from packagefiles. So we do not execute the chdir_wrapper directly now. Instead we search for a python executable and call the interpreter with the script instead.
Contributor
Author
|
libgrapheme is upstream-broken on windows. It seems to be fixed in master, so I would suggest to ignore the broken CI here. |
Gottox
force-pushed
the
fix/libgrapheme-fix-shebang
branch
2 times, most recently
from
ca466b3 to
a87407a
Compare
bgilbert
reviewed
Nov 18, 2025
Collaborator
bgilbert
left a comment
bgilbert
left a comment
There was a problem hiding this comment.
CI will require you to convert the wrap to the dependency_names provide syntax. See the CI log for details.
| 'word-test': files('../data/WordBreakTest.txt'), | ||
| } | ||
|
|
||
| chdir_wrapper = files('chdir_wrapper.py') |
Collaborator
There was a problem hiding this comment.
You should be able to undo all of these changes (including the removal of the #! line) and just change this to
Suggested change
| chdir_wrapper = files('chdir_wrapper.py') | |
| chdir_wrapper = find_program('chdir_wrapper.py') |
Meson has a special case for scripts starting with #!/usr/bin/env python3, so execute permission shouldn't be needed. However, with custom_target() this works for find_program() but not for files().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently during testing it slipped through that meson does not apply file permissions from packagefiles. So we do not execute the chdir_wrapper directly now. Instead we search for a python executable and call the interpreter with the script instead.