Possible fix for use of pin 0 as PIN_GPS_EN #6434
Conversation
|
Tested and working 👌 |
| @@ -1369,7 +1369,7 @@ GPS *GPS::createGps() | |||
|
|
|||
| GpioVirtPin *virtPin = new GpioVirtPin(); | |||
| new_gps->enablePin = virtPin; // Always at least populate a virtual pin | |||
| if (_en_gpio) { | |||
| #if defined(PIN_GPS_EN) | |||
There was a problem hiding this comment.
Won't this skip for runtime configured pins with config.position.gps_en_gpio?
There was a problem hiding this comment.
Yes, that's possible, do you think we can still go with this approach or we should switch to using our device specific #define as did for GNSS_AIROHA in the same file?
I understand there may be devices wich use GPS but don't have EN pin connected for GPS so we must use value 0 to identify those? (The issue is that with our device 0 is the correct gpio value instead...)
There was a problem hiding this comment.
Won't this skip for runtime configured pins with
config.position.gps_en_gpio?
Perhaps we could do this (?)
if(_en_gpio){
//code to execute
}
else{
#if defined(PIN_GPS_EN)
//same code to execute
#endif
There was a problem hiding this comment.
I suggest trying to modify that area rather than changing the branching here. Try and make it a generic solution rather than one specific to a board, the airoha stuff is ... not the best :)
There was a problem hiding this comment.
Alright, I'm trying to figure it out.
The issue is this probably won't support setting PIN_GPS_EN to pin 0 by app or CLI as we need a value for boards which don't have this pin. Am I right?
Thanks
There was a problem hiding this comment.
In alternative, but I don't know if that's feasible, we could use -1 as value for boards which don't use Enable pin for GPS so we could easily distinguish between zero or positive values (correct pin to use) and -1 which would mean don't use
|
Hi @fifieldt @caveman99 @thebentern any updates on what would be the best choice?
I've never seen -1 used in the Android app so I'm wondering if it would be admissible. Alternatively we could only enable pin 0 usage for boards which have Thanks! |
As discussed on Discord here
we are using PIN 0.00 on NRF52 for PIN_GPS_EN this causes an issue because if it's set to 0 this skips all the code that creates the gps enable pin instance.
I thought about this for a possible solution, this is working correctly on our board.
Will this be ok?
Thanks!