-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RAK12035VB Soil Moisture Sensor support #6259
base: master
Are you sure you want to change the base?
Conversation
5ad280f
to
fee9166
Compare
working with your code rn... still running into the same issues I was before, but just looking at what you were doing I understand more about the proto code generation and where it is coming from.. also the separate repository makes more sense to me now.. at any rate I'm still running into the same issue when the codebase is actually flashed to the device. ------------------- partial log ------------------------------------------- DEBUG | 19:53:19 8 [Router] Module 'PowerTelemetry' wantsPacket=1 So ... things I noticed when I flashed the code with your changes
Any thoughts? this is the same behavior I was running into before.. but I never understood it was not an issue UNTIL environmental telemetry was enabled... I just kept seeing the behavior as all my raks have telemetry enabled in the configs. |
gonna take a break and look at EnvironmentTelemetry in a bit... see if I can sort out what it going wrong. |
Wow, thanks for the lightening-fast response @Justin-Mann ! I'm glad the code was helpful. Good to know the RAK12035 was identified in the I2C scan! I haven't got to the actual sensor code you wrote. Things I noticed so far:
|
Created an issue to try and get PlatformIO updated: RAKWireless/RAK12035_SoilMoisture#1 |
Hmmm.. the library bugfix hold some promise.. hopin ur correct about that.
The sensor code... needs improvements.. :) currently only supporting one
sensor.
I can tell you that with previous version of the firmware.. i had this
working. Like... i have working builds. So im not 100% sure that the new
device code will help, but im hopeful..
Im just a web app developer man.. azure stuff so im outa my depth with a
lotta this. For about a month i was pondering... wtf is a protobuff.. ;)
Again thnx for the help.. would like to polish this up and make it useful
to folks.. not just me.
…On Fri, Mar 7, 2025, 6:11 PM Tom Fifield ***@***.***> wrote:
Wow, thanks for the lightening-fast response @Justin-Mann
<https://github.com/Justin-Mann> ! I'm glad the code was helpful.
Good to know the RAK12035 was identified in the I2C scan!
I haven't got to the actual sensor code you wrote. Things I noticed so far:
- There's a bugfix release of the RAK12035 library in github (1.0.4)
that is not yet in platformio (1.0.3)
- The RAK12035 library does a bit more toggling of GPIOs than I would
expect it to do. Appears to make some assumptions about the RAK environment
that may not hold in ours. eg toggling the 3.3V rail. Assuming your sensor
code is flawless, my guess is that the cause of the restart is probably
this behaviour in the RAK12035 library.
—
Reply to this email directly, view it on GitHub
<#6259 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACAFYBVKB4QPJMGBTDQU4DL2TI7U7AVCNFSM6AAAAABYRDEQTSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMBXHAZTONJRGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: fifieldt]*fifieldt* left a comment (meshtastic/firmware#6259)
<#6259 (comment)>
Wow, thanks for the lightening-fast response @Justin-Mann
<https://github.com/Justin-Mann> ! I'm glad the code was helpful.
Good to know the RAK12035 was identified in the I2C scan!
I haven't got to the actual sensor code you wrote. Things I noticed so far:
- There's a bugfix release of the RAK12035 library in github (1.0.4)
that is not yet in platformio (1.0.3)
- The RAK12035 library does a bit more toggling of GPIOs than I would
expect it to do. Appears to make some assumptions about the RAK environment
that may not hold in ours. eg toggling the 3.3V rail. Assuming your sensor
code is flawless, my guess is that the cause of the restart is probably
this behaviour in the RAK12035 library.
—
Reply to this email directly, view it on GitHub
<#6259 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACAFYBVKB4QPJMGBTDQU4DL2TI7U7AVCNFSM6AAAAABYRDEQTSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMBXHAZTONJRGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@Justin-Mann , the protobufs were merged :) |
I do the testing thing again soon as i finish my noodles man. |
@fifieldt Really do appreciate your work here.. helps me understand the repo topology and went a long way yowards me understanding where the codegen was actually happening and what defines it. Need to read a lil more.. but ill keep trying to help after this go around. See if i can continue to add support for other rak wisblock style sensors. |
37e6769
to
0c41f90
Compare
@Justin-Mann , did you get any further? |
No.. i did some basic testing, but no idea why it us failing. Ill put some
time into it today and see if i can figure it out.
Things i know..
I have a simpler version of this on an older firmware working..
I verified your pin values.
As u said.. it recognizes the device just fine..
If i enable environmental telemetry .. reboot loop.. if i unplug the
sensor.. no more loop. So its certainly when it tries to interact with the
device..
I believe my working instances also use the v1.3 of the rak12035vb library
from platformio as well (have not verified thisbyet, but will today.
I might try to remove all the guards i put in place.. ie - #ifdef RAK...
I am curious if they might be causing some issue so gonna experiment. Dont
expect that to work.. but hopefully ill sort it out today.
…On Thu, Mar 20, 2025, 11:55 PM Tom Fifield ***@***.***> wrote:
@Justin-Mann <https://github.com/Justin-Mann> , did you get any further?
—
Reply to this email directly, view it on GitHub
<#6259 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACAFYBXM3MBXCZHRYBXV5NL2VOSVHAVCNFSM6AAAAABYRDEQTSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONBSGM4DINRUHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: fifieldt]*fifieldt* left a comment (meshtastic/firmware#6259)
<#6259 (comment)>
@Justin-Mann <https://github.com/Justin-Mann> , did you get any further?
—
Reply to this email directly, view it on GitHub
<#6259 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACAFYBXM3MBXCZHRYBXV5NL2VOSVHAVCNFSM6AAAAABYRDEQTSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONBSGM4DINRUHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
So, looking at your log above, it seems that the execution dies within:
Probably at one of these lines?
|
Introduce the RAK12035 sensor as an environmental telemetry sensor, including necessary calibration checks and default values. Update relevant files to integrate the sensor into the existing telemetry system. This hardware is not just one module, but a couple.. RAK12023 and RAK12035 is the component stack, the RAK12023 does not seem to matter much and allows for multiple RAK12035 devices to be used. Co-Authored-By: @Justin-Mann
Introduce the RAK12035 sensor as an environmental telemetry sensor, including necessary calibration checks and default values. Update relevant files to integrate the sensor into the existing telemetry system.
This hardware is not just one module, but a couple.. RAK12023 and RAK12035 is the component stack, the RAK12023 does not seem to matter much and allows for multiple RAK12035 devices to be used.
Co-Authored-By: @Justin-Mann