Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sort filter dropdown arrow error #2008

Closed

Conversation

darshanlahamage
Copy link
Contributor

Description

This PR fixes #

This PR fixes the issue with the incorrect rendering of the dropdown arrow in the options menu.
Previously, the sort-by dropdown arrow was overlapping with sorting option as shown below.

Before -

option dropdown arrow error

After -

image

Notes for Reviewers

Let me know if there are additional style adjustments needed.

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Darshan Lahamage <[email protected]>
Copy link

welcome bot commented Jan 2, 2025

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Newcomers' Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

Copy link

netlify bot commented Jan 2, 2025

Deploy Preview for mesheryio-preview ready!

Name Link
🔨 Latest commit 7c801d1
🔍 Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/67a1a2275e1f830008fcbf2a
😎 Deploy Preview https://deploy-preview-2008--mesheryio-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SAHU-01
Copy link
Contributor

SAHU-01 commented Jan 5, 2025

Thank you for your contribution @darshanlahamage !
Let's discuss this during the website call on Monday(6th Jan 2025) at 6:30 PM IST

Add it as an agenda item to the meeting minutes, if you would.

@vishalvivekm
Copy link
Contributor

Thank you for your contribution @darshanlahamage ! Let's discuss this during the website call on Monday(6th Jan 2025) at 6:30 PM IST

Add it as an agenda item to the meeting minutes, if you would.

added ✅ // @darshanlahamage

Copy link
Member

@aakankshabhende aakankshabhende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@darshanlahamage could you please link the issue you fixed?

@darshanlahamage
Copy link
Contributor Author

@darshanlahamage could you please link the issue you fixed?

Have not raised issue yet nor associated to any existing one

@leecalcote
Copy link
Member

@vishalvivekm, please review, fix merge conflict, accept, merge.

Copy link

stale bot commented Mar 7, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Mar 7, 2025
Copy link

stale bot commented Mar 15, 2025

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

@stale stale bot closed this Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/website issue/stale Issue has not had any activity for an extended period of time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants