add UI_NO_HIBERNATE build flag to disable hibernate screen - #3290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new
UI_NO_HIBERNATEbuild flag and applies it to the Wio Tracker L1 BLE and USB variants.The build flag will prevent the hibernate screen from showing at the end of the companion UI.
I frequently find my Wio Tracker L1 has been hibernated due to the joystick and enter button being knocked around in my pocket. As this node has a physical power switch, the hibernate mode doesn't really provide any benefit to the user.
So, for this variant it has been removed.
We could potentially add a new "screen lock" key combo to prevent other pages, such as advert and gps from being accidentally toggled, however the new build flag was a simpler approach for the current use case.