Skip to content

Conversation

@j0g3sc
Copy link
Collaborator

@j0g3sc j0g3sc commented Oct 21, 2025

CU-86c63jkw8
Issue #64

@j0g3sc j0g3sc force-pushed the 64-bug-unexpected-new-value-spec-inconsistent-values-for-sensitive-attribute branch from 557923b to 05ad7f3 Compare October 21, 2025 15:45
@j0g3sc j0g3sc requested review from Copilot and nroi October 21, 2025 15:54
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements handling for obfuscated secrets in the meshPlatform API. The API returns secrets as obfuscated values (mesh/hidden-secret) rather than plain text, so this change ensures that the actual secret values from the plan/state are preserved when reading from the API.

Key changes:

  • Added a new utility function to handle obfuscated secrets across all platform types (AKS, AWS, Azure, GCP, Kubernetes, OpenShift)
  • Integrated obfuscation handling into Create, Read, and Update operations
  • Marked sensitive fields appropriately in the schema

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
internal/provider/platform_resource_obfuscationhandling.go New file containing the core logic for detecting and replacing obfuscated secrets with actual values from plan/state
internal/provider/platform_resource.go Integrated obfuscation handling into CRUD operations and marked access_token as sensitive
docs/resources/platform.md Updated documentation to reflect that access_token is now marked as sensitive

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@j0g3sc j0g3sc force-pushed the 64-bug-unexpected-new-value-spec-inconsistent-values-for-sensitive-attribute branch from 05ad7f3 to acc6bd6 Compare October 21, 2025 18:23
@j0g3sc j0g3sc marked this pull request as ready for review October 21, 2025 18:23
Copy link
Contributor

@nroi nroi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@j0g3sc j0g3sc merged commit ceac56b into main Oct 22, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] unexpected new value: .spec: inconsistent values for sensitive attribute

3 participants