Fix optional types not registering as such outside of TS strict mode #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromepl
commented
Feb 5, 2023
Comment on lines
-443
to
+438
| return t.unionNode([t.elementNode('node'), t.undefinedNode()]); | ||
| return t.unionNode([t.undefinedNode(), t.elementNode('node')]); |
There was a problem hiding this comment.
Using the convention that undefinedNode always comes first in a unionNode makes it easy to compare the expected to actual objects in the tests.
This was the quick fix instead of creating a matcher for jest that would ignore array order within union nodes.
It's also why I had to change a couple of the output.json test files to reorder elements.
|
@merceyz have you had a chance to take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a project with
strictTS config turned off, I discovered that the generated propTypes were always marked withisRequiredThis PR fixes this and adds testing for this additional typescript config scenario.
Reviewing with whitespace changes turned off will make it easier to review
test/index.test.ts