feat(image-cropper-web): allow custom aspect ratio width/height as expressions#2333
feat(image-cropper-web): allow custom aspect ratio width/height as expressions#2333hunter-koppen wants to merge 1 commit into
Conversation
…pressions Convert the customAspectWidth/customAspectHeight properties from static integers to Integer-returning expressions so app developers can bind an attribute (or any expression) to the ratio sides instead of a fixed value. The store now reads each DynamicValue<Big> via ValueStatus.Available guard, resolveAspectRatio tolerates undefined, and the editor preview parses the expression text (numeric literals only) with a free-aspect fallback. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Hello maker! Thank you for opening a pull request to the `web-widgets` repository and helping us make our widgets better. 💙 A small note from the maintainers: We know that you probably wish to see your cool new feature or fix ASAP, but bringing a new feature to the widget is a small journey. But don't be scared! We just need time to triage, test, and analyze this feature or fix. We may request XML, code, or other changes that may be needed to match our desired look and feel for the new feature. We, as maintainers, strive to make sure that every change made in the code doesn't break existing behavior. For now, here is what will happen next:
IMPORTANT: This repository uses code checks (linters, tests, etc.). Someone from our team will trigger these checks for your PR. In short, we will not proceed with your PR until all checks are green. It's the PR owner's goal to make checks green; maintainers are not going to do it for you. * TotW — Tech of the Week |
Convert the customAspectWidth/customAspectHeight properties from static integers to Integer-returning expressions so mendix developers can bind an attribute (or any expression) to the ratio sides instead of a fixed value.
The store now reads each DynamicValue via ValueStatus.Available guard, resolveAspectRatio tolerates undefined, and the editor preview parses the expression text (numeric literals only) with a free-aspect fallback.