Skip to content

[WC-3418] Combobox accessibility improvements#2281

Open
HedwigAR wants to merge 5 commits into
mainfrom
feature/combobox-validation-improvements
Open

[WC-3418] Combobox accessibility improvements#2281
HedwigAR wants to merge 5 commits into
mainfrom
feature/combobox-validation-improvements

Conversation

@HedwigAR

Copy link
Copy Markdown
Contributor

Pull request type

Bug fix (non-breaking change which fixes an issue)


Description

Fixes two WCAG accessibility violations in the combobox widget.

  1. Decorative icons hidden from screen readers: Added aria-hidden="true" to DownArrow and ClearButton icon wrappers to prevent "image" announcements
  2. Empty menu structures removed from accessibility tree: Menu <ul> now only renders when open, preventing screen readers from navigating to empty groups

What should be covered while testing?

Screen Reader Testing:

  • Verify decorative icons (arrow, clear button) are NOT announced as "image"
  • Verify no empty list structures when menu is closed
  • Verify clear button announces with proper label text

Functional Testing:

  • Test keyboard navigation (Tab, Enter, Arrow keys, Escape)
  • Test single and multi-selection modes
  • Verify validation attributes (aria-invalid, aria-describedby) still work

@HedwigAR HedwigAR requested a review from a team as a code owner June 19, 2026 10:41
@HedwigAR HedwigAR changed the title Combobox accessibility improvements [WC-3418] Combobox accessibility improvements Jun 19, 2026
@github-actions

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants