fix(combobox): correct filtering when only one character is typed#2136
Closed
msoaresms wants to merge 1 commit into
Closed
fix(combobox): correct filtering when only one character is typed#2136msoaresms wants to merge 1 commit into
msoaresms wants to merge 1 commit into
Conversation
iobuhov
approved these changes
Jun 10, 2026
Issue: filtering did not work correctly when only one character was entered. Root cause: startsWith search option was using WORD_STARTS_WITH. Solution: replaced WORD_STARTS_WITH with STARTS_WITH.
Collaborator
yordan-st
approved these changes
Jun 23, 2026
Collaborator
|
Thanks for the PR. However, we will close this one for now, as the behaviour tested is effectively the same: with one-character input and single-word options, both versions produce the same results. The threshold change (from WORD_STARTS_WITH to STARTS_WITH) only affects multi-word options, which weren't included in this validation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: filtering did not work correctly when only one character was entered.
Root cause: startsWith search option was using WORD_STARTS_WITH.
Solution: replaced WORD_STARTS_WITH with STARTS_WITH.
Pull request type
Description