Skip to content

fix: release script on windows #2021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
r0b1n merged 1 commit into from
Jan 7, 2026
Merged

fix: release script on windows #2021

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion automation/utils/src/bump-version.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
}

export function bumpPackageJson(path: string, version: string): void {
spawnSync("npm", ["version", version], { cwd: path });
spawnSync("pnpm", ["version", version], { cwd: path });
}

export async function bumpXml(path: string, version: string): Promise<boolean> {
Expand All @@ -36,7 +36,7 @@
return true;
}
return false;
} catch (e) {

Check warning on line 39 in automation/utils/src/bump-version.ts

View workflow job for this annotation

GitHub Actions / Run code quality check 

'e' is defined but never used. Allowed unused caught errors must match /^_/u
throw new Error("package.xml not found");
}
}
Expand Down
8 changes: 5 additions & 3 deletions automation/utils/src/prepare-release-helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,15 +35,17 @@ type PackagesFullInfoMap = Map<string, PackagesFullInfo>;
async function loadPackagesFullInfo(packages: PackageListing[]): Promise<PackagesFullInfoList> {
const results: PackagesFullInfoList = [];
for (const pkg of packages) {
if (pkg.path.includes("/pluggableWidgets/")) {
const normalizedPath = pkg.path.replace(/\\/g, "/");

if (normalizedPath.includes("/pluggableWidgets/")) {
try {
const widgetInfo = await getWidgetInfo(pkg.path);
const changelog = await getWidgetChangelog(pkg.path);
results.push([pkg, widgetInfo, changelog]);
} catch (_e) {
// ignore or log error
}
} else if (pkg.path.includes("/modules/")) {
} else if (normalizedPath.includes("/modules/")) {
try {
const moduleInfo = await getModuleInfo(pkg.path);
const changelog = await getModuleChangelog(pkg.path, moduleInfo.mxpackage.name);
Expand Down Expand Up @@ -107,7 +109,7 @@ function createPackagesTree(map: PackagesFullInfoMap, list: PackagesFullInfoList
}

export async function selectPackageV2(): Promise<WidgetPkg | ModulePkg> {
const pkgs = await listPackages(["'*'", "!web-widgets"]);
const pkgs = await listPackages(['"*"', '"!web-widgets"']);
const pkgsList = await loadPackagesFullInfo(pkgs);
const pkgsMap = createPackagesMap(pkgsList);
const pkgsTree = createPackagesTree(pkgsMap, pkgsList);
Expand Down
Loading