[WC-2886]: DG2 Filters floating positioning fix #1526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iobuhov
reviewed
Apr 9, 2025
| ))} | ||
| </ul> | ||
| {open && ( | ||
| <FloatingPortal> |
There was a problem hiding this comment.
This will probably cause z-index issues
There was a problem hiding this comment.
Other option was to switch the floatingUI strategy(position) to absolute, which I believe would cause even more issues, I'll see the e2e's to make sure.
There was a problem hiding this comment.
The snapshot tests are also passing, you think we can head on? @iobuhov
There was a problem hiding this comment.
Ok, no problem. I think can be tested by Leo
rahmanunver
force-pushed
the
fix/wc-2886_dg2_filter_popup
branch
from
c78f538 to
d3b7ba0
Compare
gjulivan
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Bug fix (non-breaking change which fixes an issue)
Description
Fix an issue where mount/unmount of a filter popup causes it to lose it's capability to observe it's own position.