Draft: Add new exception types for different GitErrorCodes

.github/workflows/Build_and_publish_package.yml

@@ -0,0 +1,42 @@
+name: Build and Deploy Packages
+
+on:
+  pull_request:
+  push:
+    branches:
+      - main
+
+jobs:
+  build:
+    # Currently we build LibGit2Sharp for Windows only
+    # See: https://docs.github.com/en/actions/configuring-and-managing-workflows/configuring-a-workflow#configuring-a-build-matrix
+    runs-on: windows-2019
+
+    steps:
+    # Checkout repo into build area
+    - uses: actions/checkout@v3
+      with:
+        fetch-depth: 0 # avoid shallow clone so Nerdbank.GitVersioning can do its work.
+
+    # Build and deploy nuget package
+    # We include the GitHub package source so that we can reference current packages and also so that we can push to the package repo
+    - name: Build Project and Package
+      run: |
+        dotnet nuget add source "https://nuget.pkg.github.com/mendix/index.json" --name "GitHub" --username ${{ secrets.GHPACKAGESUSER }} --password ${{ secrets.GHPACKAGESTOKEN }}
+        dotnet pack --configuration Release --output "mx_nuget" -p:PublicRelease=true LibGit2Sharp/LibGit2Sharp.csproj
+      shell: powershell #Keep as powershell and not pwsh
+
+    - name: Upload build artifacts
+      uses: actions/upload-artifact@v3
+      with:
+        name: nuget package
+        path: ${{ github.workspace }}/**/*.nupkg
+
+    # After build we copy the binaries to package output folder
+    # Finally we pack and push the package to github packages
+    - name: Deploy Package
+      if: github.event_name == 'push' && github.ref == 'refs/heads/main'
+      run: |
+        dotnet nuget add source "https://nuget.pkg.github.com/mendix/index.json" --name "GitHub" --username ${{ secrets.GHPACKAGESUSER }} --password ${{ secrets.GHPACKAGESTOKEN }}
+        dotnet nuget push "**/mx_nuget/Mendix.LibGit2Sharp*.nupkg" --source "GitHub" --skip-duplicate
+      shell: powershell #Keep as powershell and not pwsh

LibGit2Sharp.Tests/CloneFixture.cs

@@ -43,7 +43,7 @@ public void CanCloneWithCheckoutBranchName(string branchName, string headTipId)
         {
             var scd = BuildSelfCleaningDirectory();
 
-            string clonedRepoPath = Repository.Clone(BareTestRepoPath, scd.DirectoryPath, new CloneOptions { BranchName = branchName });
+            string clonedRepoPath = Repository.Clone(BareTestRepoPath, scd.DirectoryPath, new CloneOptions { BranchName = branchName }, new ProxyOptions());
 
             using (var repo = new Repository(clonedRepoPath))
             {
@@ -107,7 +107,7 @@ public void CanCloneBarely(string url)
             string clonedRepoPath = Repository.Clone(url, scd.DirectoryPath, new CloneOptions
             {
                 IsBare = true
-            });
+            }, new ProxyOptions());
 
             using (var repo = new Repository(clonedRepoPath))
             {
@@ -130,7 +130,7 @@ public void WontCheckoutIfAskedNotTo(string url)
             string clonedRepoPath = Repository.Clone(url, scd.DirectoryPath, new CloneOptions()
             {
                 Checkout = false
-            });
+            }, new ProxyOptions());
 
             using (var repo = new Repository(clonedRepoPath))
             {
@@ -155,7 +155,7 @@ public void CallsProgressCallbacks(string url)
                 OnProgress = progress => { progressWasCalled = true; return true; },
                 OnUpdateTips = (name, oldId, newId) => { updateTipsWasCalled = true; return true; },
                 OnCheckoutProgress = (a, b, c) => checkoutWasCalled = true
-            });
+            }, new ProxyOptions());
 
             Assert.True(transferWasCalled);
             Assert.True(progressWasCalled);
@@ -175,7 +175,7 @@ public void CanCloneWithCredentials()
                 new CloneOptions()
                 {
                     CredentialsProvider = Constants.PrivateRepoCredentials
-                });
+                }, new ProxyOptions());
 
 
             using (var repo = new Repository(clonedRepoPath))
@@ -289,7 +289,7 @@ public void CanInspectCertificateOnClone(string url, string hostname, Type certT
             };
 
             Assert.Throws<UserCancelledException>(() =>
-                Repository.Clone(url, scd.DirectoryPath, options)
+                Repository.Clone(url, scd.DirectoryPath, options, new ProxyOptions())
             );
 
             Assert.True(wasCalled);
@@ -437,7 +437,7 @@ public void CanRecursivelyCloneSubmodules()
                 RepositoryOperationCompleted = repositoryOperationCompleted,
             };
 
-            string clonedRepoPath = Repository.Clone(uri.AbsolutePath, scd.DirectoryPath, options);
+            string clonedRepoPath = Repository.Clone(uri.AbsolutePath, scd.DirectoryPath, options, new ProxyOptions());
             string workDirPath;
 
             using (Repository repo = new Repository(clonedRepoPath))
@@ -521,7 +521,7 @@ public void CanCancelRecursiveClone()
             };
 
             Assert.Throws<UserCancelledException>(() =>
-                Repository.Clone(uri.AbsolutePath, scd.DirectoryPath, options));
+                Repository.Clone(uri.AbsolutePath, scd.DirectoryPath, options, new ProxyOptions()));
 
             // Cancel after super repository is cloned, but before submodule is cloned.
             cancelDepth = 1;
@@ -530,7 +530,7 @@ public void CanCancelRecursiveClone()
 
             try
             {
-                Repository.Clone(uri.AbsolutePath, scd.DirectoryPath, options);
+                Repository.Clone(uri.AbsolutePath, scd.DirectoryPath, options, new ProxyOptions());
             }
             catch (RecurseSubmodulesException ex)
             {
@@ -562,7 +562,7 @@ public void CannotCloneWithForbiddenCustomHeaders()
                 FetchOptions = new FetchOptions { CustomHeaders = new String[] { knownHeader } }
             };
 
-            Assert.Throws<LibGit2SharpException>(() => Repository.Clone(url, scd.DirectoryPath, cloneOptions));
+            Assert.Throws<LibGit2SharpException>(() => Repository.Clone(url, scd.DirectoryPath, cloneOptions, new ProxyOptions()));
         }
 
         [Fact]
@@ -578,7 +578,7 @@ public void CannotCloneWithMalformedCustomHeaders()
                 FetchOptions = new FetchOptions { CustomHeaders = new String[] { knownHeader } }
             };
 
-            Assert.Throws<LibGit2SharpException>(() => Repository.Clone(url, scd.DirectoryPath, cloneOptions));
+            Assert.Throws<LibGit2SharpException>(() => Repository.Clone(url, scd.DirectoryPath, cloneOptions, new ProxyOptions()));
         }
 
         [Fact]
@@ -594,7 +594,7 @@ public void CanCloneWithCustomHeaders()
                 FetchOptions = new FetchOptions { CustomHeaders = new String[] { knownHeader } }
             };
 
-            var clonedRepoPath = Repository.Clone(url, scd.DirectoryPath, cloneOptions);
+            var clonedRepoPath = Repository.Clone(url, scd.DirectoryPath, cloneOptions, new ProxyOptions());
             Assert.True(Directory.Exists(clonedRepoPath));
         }
     }

LibGit2Sharp.Tests/FetchFixture.cs

@@ -2,6 +2,7 @@
 using System.Collections.Generic;
 using System.IO;
 using System.Linq;
+using LibGit2Sharp.Core;
 using LibGit2Sharp.Tests.TestHelpers;
 using Xunit;
 
@@ -42,7 +43,7 @@ public void CanFetchIntoAnEmptyRepository(string url)
                 }
 
                 // Perform the actual fetch
-                Commands.Fetch(repo, remoteName, new string[0], new FetchOptions { OnUpdateTips = expectedFetchState.RemoteUpdateTipsHandler }, null);
+                Commands.Fetch(repo, remoteName, new string[0], new FetchOptions { OnUpdateTips = expectedFetchState.RemoteUpdateTipsHandler }, null, new ProxyOptions());
 
                 // Verify the expected
                 expectedFetchState.CheckUpdatedReferences(repo);
@@ -65,7 +66,7 @@ public void CanFetchIntoAnEmptyRepositoryWithCredentials()
                 Commands.Fetch(repo, remoteName, new string[0], new FetchOptions
                 {
                     CredentialsProvider = Constants.PrivateRepoCredentials
-                }, null);
+                }, null, new ProxyOptions());
             }
         }
 
@@ -102,7 +103,7 @@ public void CanFetchAllTagsIntoAnEmptyRepository(string url)
                 {
                     TagFetchMode = TagFetchMode.All,
                     OnUpdateTips = expectedFetchState.RemoteUpdateTipsHandler
-                }, null);
+                }, null, new ProxyOptions());
 
                 // Verify the expected
                 expectedFetchState.CheckUpdatedReferences(repo);
@@ -148,7 +149,7 @@ public void CanFetchCustomRefSpecsIntoAnEmptyRepository(string url, string local
                 {
                     TagFetchMode = TagFetchMode.None,
                     OnUpdateTips = expectedFetchState.RemoteUpdateTipsHandler
-                }, null);
+                }, null, new ProxyOptions());
 
                 // Verify the expected
                 expectedFetchState.CheckUpdatedReferences(repo);
@@ -179,7 +180,7 @@ public void FetchRespectsConfiguredAutoTagSetting(TagFetchMode tagFetchMode, int
                     r => r.TagFetchMode = tagFetchMode);
 
                 // Perform the actual fetch.
-                Commands.Fetch(repo, remoteName, new string[0], null, null);
+                Commands.Fetch(repo, remoteName, new string[0], null, null, null);
 
                 // Verify the number of fetched tags.
                 Assert.Equal(expectedTagCount, repo.Tags.Count());
@@ -197,7 +198,7 @@ public void CanFetchAllTagsAfterAnInitialClone()
 
             using (var repo = new Repository(clonedRepoPath))
             {
-                Commands.Fetch(repo, "origin", new string[0], new FetchOptions { TagFetchMode = TagFetchMode.All }, null);
+                Commands.Fetch(repo, "origin", new string[0], new FetchOptions { TagFetchMode = TagFetchMode.All }, null, new ProxyOptions());
             }
         }
 
@@ -223,17 +224,17 @@ public void FetchHonorsTheFetchPruneConfigurationEntry()
 
                 // No pruning when the configuration entry isn't defined
                 Assert.Null(clonedRepo.Config.Get<bool>("fetch.prune"));
-                Commands.Fetch(clonedRepo, "origin", new string[0], null, null);
+                Commands.Fetch(clonedRepo, "origin", new string[0], null, null, null);
                 Assert.Equal(5, clonedRepo.Branches.Count(b => b.IsRemote && b.FriendlyName != "origin/HEAD"));
 
                 // No pruning when the configuration entry is set to false
                 clonedRepo.Config.Set<bool>("fetch.prune", false);
-                Commands.Fetch(clonedRepo, "origin", new string[0], null, null);
+                Commands.Fetch(clonedRepo, "origin", new string[0], null, null, null);
                 Assert.Equal(5, clonedRepo.Branches.Count(b => b.IsRemote && b.FriendlyName != "origin/HEAD"));
 
                 // Auto pruning when the configuration entry is set to true
                 clonedRepo.Config.Set<bool>("fetch.prune", true);
-                Commands.Fetch(clonedRepo, "origin", new string[0], null, null);
+                Commands.Fetch(clonedRepo, "origin", new string[0], null, null, null);
                 Assert.Equal(4, clonedRepo.Branches.Count(b => b.IsRemote && b.FriendlyName != "origin/HEAD"));
             }
         }
@@ -251,7 +252,8 @@ public void CannotFetchWithForbiddenCustomHeaders()
             var options = new FetchOptions { CustomHeaders = new String[] { knownHeader } };
             using (var repo = new Repository(clonedRepoPath))
             {
-                Assert.Throws<LibGit2SharpException>(() => Commands.Fetch(repo, "origin", new string[0], options, null));
+                var ex = Assert.Throws<LibGit2SharpException>(() => Commands.Fetch(repo, "origin", new string[0], options, null, new ProxyOptions()));
+                Assert.Equal(GitErrorCategory.Invalid, ex.Category);
             }
         }
 
@@ -268,7 +270,7 @@ public void CanFetchWithCustomHeaders()
             var options = new FetchOptions { CustomHeaders = new String[] { knownHeader } };
             using (var repo = new Repository(clonedRepoPath))
             {
-                Commands.Fetch(repo, "origin", new string[0], options, null);
+                Commands.Fetch(repo, "origin", new string[0], options, null, new ProxyOptions());
             }
         }
 
@@ -285,7 +287,7 @@ public void CannotFetchWithMalformedCustomHeaders()
             var options = new FetchOptions { CustomHeaders = new String[] { knownHeader } };
             using (var repo = new Repository(clonedRepoPath))
             {
-                Assert.Throws<LibGit2SharpException>(() => Commands.Fetch(repo, "origin", new string[0], options, null));
+                Assert.Throws<LibGit2SharpException>(() => Commands.Fetch(repo, "origin", new string[0], options, null, new ProxyOptions()));
             }
         }