fix: partial bypass of path based access restrictions #867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
indra0007
force-pushed
the
fix-semicolon-requset-uri-issue
branch
from
6a6a248 to
e6fb5a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY is this change required?
A high security bug was raised . This is to address that bug.
What customer problem is being addressed?
There is a vulnerability in java which delete
;from any uri if exists. As a result anyone can exploit this and can get access of restricted items. For example, lets say a custom wanted to block/ws/route for outside world. The endpoint should be visible only from selected IPs. Customer customised/ws/route ro to achieve the same. But if some outsider typeshttps://<domain name>/ws;/<service name>then/ws/specific route will not be matched rather it would match the default/route. Thus user will not be restricted. And in the backend java will strip;so as a resulthttps://<domain name>/ws;/<service name>will effectively becomehttps://<domain name>/ws/<service name>and even outsider get access of restricted resourcesUse customer persona to define the problem e.g. Andrei is unable to...
Include any links to other MRs, stories, slack discussions, etc... that will help establish context.
Do we need to inform others of this change, and if so, are they informed?
For instance, is octoman affected (dep), plugin teams, support? When in doubt, overcommunicate.
Please provide Acceptance Criteria for this change?
Outsider should not be able to get access of restricted resources by exploiting java's ; stripping behaviour.