Flag to enable or disable microflow execution error pop-up #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added feature to disable / enable error pop-up - Bumped up the version to 4.0.2
- Updated default error pop-up settings to true
- Updated default error pop-up to true
|
I would add a colon and space to separate the first part of the message and the actual error text. That is already an issue and is not fixed here. |
|
Agree, this feature should not have been implemented. We place it in our blacklog to revert this change that added the popup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the newer version, all the microflow or nanoflow execution errors are logged in the console and are also shown in a pop-up.
This becomes a little annoying when the timer widget is used to refresh the content on a page, the page will be filled with pop-ups in case of temporary issues in the backend server.
In certain cases, it would be nice to have a feature to enable or disable the pop-up.
This pull request has those changes.
Request to have a look and merge if its found useful.