fix: got rid of typescript-enums, improved types of exported functions#248
Closed
DJanocha wants to merge 1 commit intomelwynfurtado:masterfrom
Closed
fix: got rid of typescript-enums, improved types of exported functions#248DJanocha wants to merge 1 commit intomelwynfurtado:masterfrom
DJanocha wants to merge 1 commit intomelwynfurtado:masterfrom
Conversation
|
|
||
| export const postcodeValidator = (postcode: string, country: string): boolean => { | ||
| if (!POSTCODE_REGEXES.has(country)) { | ||
| export type OtherStringOr<T extends string> = T | (string & {}); |
Owner
There was a problem hiding this comment.
Firstly, thanks for making these changes.
Could we not just use the CountryCode type directly as the function throws on unrecognised country codes?
|
Stale pull request message |
|
Stale pull request message |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
for improving typings of lib's API
Who should review this PR?
whoever
Questions: