Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OZ-668: Add placeholder credentials for docker server in settings.xml #41

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OZ-668: Add placeholder credentials for docker server in settings.xml #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/maven-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,8 @@ jobs:
},
{
"id": "docker.io",
"username": "${{ secrets.DOCKER_HUB_USERNAME || ''}}",
"password": "${{ secrets.DOCKER_HUB_PASSWORD || ''}}"
"username": "${{ secrets.DOCKER_HUB_USERNAME || 'username'}}",
"password": "${{ secrets.DOCKER_HUB_PASSWORD || 'password'}}"
Comment on lines +97 to +98
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hadn't seen this but still fails.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But we need to merge it no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is why the HSC builds are failing

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed this commit, I hadn't seen this PR

}]

- name: Publish maven artifacts
Expand Down