OZ-819: Odoo OIDC add-on to work for Odoo 17 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip IDP logout if user has no IDP account Fixed IDP redirect url to include base URL and logout URL to provider form Skip IDP logout of no logout URL is configured for the provider Fixed logout for user with no IDP account Added support for params in logout URL and encoded post redirect URL Updated logout URL's help tip to mention it maps to end_session_endpoint Added support for full URLs as redirects Allow redirect URLs containing http or https but do not start with them Apply formatting changes Apply formatting changes Apply formatting changes Renamed logout_endpoint to end_session_endpoint Switched to using urllib.parse.urljoin Switched to using urllib to parse, create urls and query params Added initial test for oidc logout Added more tests for oidc logout Cleaned up test to verify individual redirect url components Use url_root instead of web base url Applied changes as requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://mekomsolutions.atlassian.net/browse/OZ-819