Add experimental Network API #600
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellnix
force-pushed
the
proxy-search
branch
2 times, most recently
from
f3be092 to
e290cfb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #600 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 11 +1
Lines 796 806 +10
=========================================
+ Hits 796 806 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated for the current state of the network API.
Fixes #609
Old description, not relevant anymore:
Initial implementation of sharding via
/network/*endpoints and federated search, planned for 1.13.See integration issue:
meilisearch/integration-guides#314
While this PR contains tests, they have not yet been run. None of the code has been run really, you can think of it more as pseudocode. It definitely has errors.
The purpose of starting the PR so early was to do some groundwork to support 1.13 on release day, in addition to starting some discussion about naming various endpoints and testing proxy search by running two Meilisearch instances.
Currently, the API specification is not great, so it's possible I misunderstood it. The code samples are just guesses by me.
Please provide feedback on the comments (or any fishy code).