Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add husky and configure lint-staged #1861

Merged
merged 9 commits into from
Mar 18, 2025

Conversation

flevi29
Copy link
Collaborator

@flevi29 flevi29 commented Feb 2, 2025

Pull Request

lint-staged wasn't set up properly and wasn't running before. I hope this PR fixes that.

What does this PR do?

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@flevi29 flevi29 added the maintenance Issue about maintenance (CI, tests, refacto...) label Feb 2, 2025
@flevi29 flevi29 requested a review from Strift February 2, 2025 10:02
Copy link

codecov bot commented Feb 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.36%. Comparing base (9e43b62) to head (0522724).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1861   +/-   ##
=======================================
  Coverage   99.36%   99.36%           
=======================================
  Files          16       16           
  Lines        1566     1566           
  Branches      343      343           
=======================================
  Hits         1556     1556           
  Misses         10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Strift
Strift previously approved these changes Feb 27, 2025
Copy link
Collaborator

@Strift Strift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@flevi29
Copy link
Collaborator Author

flevi29 commented Feb 28, 2025

bors cancel

@flevi29 flevi29 requested a review from Strift March 15, 2025 08:21
Copy link
Collaborator

@Strift Strift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be working as far as I can tell. Thanks for this!

bors merge

@Strift
Copy link
Collaborator

Strift commented Mar 18, 2025

bors cancel

(I don't know why bors is crashing here)

@flevi29
Copy link
Collaborator Author

flevi29 commented Mar 18, 2025

@curquiza Can we merge manually?

@flevi29
Copy link
Collaborator Author

flevi29 commented Mar 18, 2025

@flevi29
Copy link
Collaborator Author

flevi29 commented Mar 18, 2025

bors ping

Copy link
Contributor

meili-bors bot commented Mar 18, 2025

pong

@flevi29
Copy link
Collaborator Author

flevi29 commented Mar 18, 2025

bors retry

Copy link
Contributor

meili-bors bot commented Mar 18, 2025

pong

@flevi29
Copy link
Collaborator Author

flevi29 commented Mar 18, 2025

bors merge

@flevi29
Copy link
Collaborator Author

flevi29 commented Mar 18, 2025

bors cancel

@flevi29
Copy link
Collaborator Author

flevi29 commented Mar 18, 2025

bors d+

Copy link
Contributor

meili-bors bot commented Mar 18, 2025

✌️ flevi29 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@flevi29
Copy link
Collaborator Author

flevi29 commented Mar 18, 2025

bors r+

@flevi29
Copy link
Collaborator Author

flevi29 commented Mar 18, 2025

It's probably time to switch to https://github.blog/news-insights/product-news/github-merge-queue-is-generally-available/

@flevi29 flevi29 merged commit d6446f5 into meilisearch:main Mar 18, 2025
7 of 8 checks passed
@flevi29 flevi29 deleted the lint-staged-husky branch March 18, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issue about maintenance (CI, tests, refacto...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants