Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom TypeScript ESLint rules and adapt code, fix HttpRequests issue where timeout errors sometimes weren't properly thrown #1749

Merged
merged 19 commits into from
Mar 26, 2025

Conversation

Barabasbalazs
Copy link
Contributor

@Barabasbalazs Barabasbalazs commented Oct 21, 2024

Pull Request

Related issues

What does this PR do?

  • removes TypeScript specific ESLint rule exceptions and adjusts the code accordingly

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 5 lines in your changes missing coverage. Please review.

Project coverage is 99.17%. Comparing base (1b6660d) to head (a7fe10e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/meilisearch.ts 28.57% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1749      +/-   ##
==========================================
- Coverage   99.36%   99.17%   -0.20%     
==========================================
  Files          16       16              
  Lines        1575     1574       -1     
  Branches      345      348       +3     
==========================================
- Hits         1565     1561       -4     
- Misses         10       13       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@flevi29 flevi29 self-requested a review October 21, 2024 17:55
@flevi29 flevi29 added the maintenance Issue about maintenance (CI, tests, refacto...) label Oct 21, 2024
@flevi29
Copy link
Collaborator

flevi29 commented Oct 21, 2024

https://github.com/meilisearch/meilisearch-js/blob/main/eslint.config.js#L47-L59

Also remove these, except for @typescript-eslint/no-unused-vars.

Copy link
Collaborator

@flevi29 flevi29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The above.

@flevi29 flevi29 marked this pull request as draft October 21, 2024 21:10
@Barabasbalazs Barabasbalazs marked this pull request as ready for review October 22, 2024 08:51
Copy link
Collaborator

@flevi29 flevi29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, jusqu'ici pour va bien.

@flevi29 flevi29 marked this pull request as draft October 22, 2024 08:54
@Barabasbalazs Barabasbalazs requested a review from flevi29 October 22, 2024 08:54
@flevi29
Copy link
Collaborator

flevi29 commented Oct 22, 2024

Let's leave this as a draft, because #1741 has to be merged first.

@Barabasbalazs Barabasbalazs marked this pull request as ready for review October 22, 2024 08:58
@Barabasbalazs Barabasbalazs marked this pull request as draft October 22, 2024 09:06
@flevi29 flevi29 marked this pull request as ready for review March 25, 2025 15:11
@Strift
Copy link
Collaborator

Strift commented Mar 26, 2025

The tests cannot run because of conflicts. It would be best to rebase this PR and only include changes related to eslint rules to make reviewing easier.

@flevi29 flevi29 force-pushed the ts-eslint-rules-cleanup branch from e311f89 to b90448d Compare March 26, 2025 07:55
@flevi29 flevi29 changed the title TS eslint rules cleanup Remove custom TypeScript ESLint rules and adapt code, fix HttpRequests issue where timeout errors sometimes weren't properly thrown Mar 26, 2025
@flevi29 flevi29 added the bug Something isn't working label Mar 26, 2025
@flevi29 flevi29 merged commit 43c7c5c into meilisearch:main Mar 26, 2025
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working maintenance Issue about maintenance (CI, tests, refacto...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Abort errors are not caught from response.text() Turn on TypeScript recommended ESLint rules
3 participants