-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove custom TypeScript ESLint rules and adapt code, fix HttpRequests
issue where timeout errors sometimes weren't properly thrown
#1749
Remove custom TypeScript ESLint rules and adapt code, fix HttpRequests
issue where timeout errors sometimes weren't properly thrown
#1749
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1749 +/- ##
==========================================
- Coverage 99.36% 99.17% -0.20%
==========================================
Files 16 16
Lines 1575 1574 -1
Branches 345 348 +3
==========================================
- Hits 1565 1561 -4
- Misses 10 13 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
https://github.com/meilisearch/meilisearch-js/blob/main/eslint.config.js#L47-L59 Also remove these, except for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, jusqu'ici pour va bien.
Let's leave this as a draft, because #1741 has to be merged first. |
The tests cannot run because of conflicts. It would be best to rebase this PR and only include changes related to eslint rules to make reviewing easier. |
…nt builds with ts
e311f89
to
b90448d
Compare
HttpRequests
issue where timeout errors sometimes weren't properly thrown
Pull Request
Related issues
response.text()
#1893What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!