Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker compose and pre-release tests to net 8 #618

Merged
merged 3 commits into from
Mar 30, 2025

Conversation

danFbach
Copy link
Contributor

Pull Request

What does this PR do?

  • updates docker-compose.yml from dotnet 6 to dotnet 8
  • updates pre-release-tests.yml from dotnet 3 to dotnet 8
  • should have done this when i updated the other dotnet versions!

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! It looks good to me, but I don't knowwe need to let the users know... Is this mean we are deprecating usage of previous versions?

@danFbach
Copy link
Contributor Author

hi @brunoocasali,
I'm not a docker master, but doesn't this just define docker dependencies and docker installs them for you? isn't that the point of docker - the user doesn't need to be aware of these changes?
I did this because we just bumped the rest of the repo to dotnet 8, so I thought it appropriate to also bump the docker dotnet version.

@danFbach
Copy link
Contributor Author

@brunoocasali and to answer your question - dotnet packages are often, but not always, backwards compatible. Here's some documentation .

@brunoocasali
Copy link
Member

I did this because we just bumped the rest of the repo to dotnet 8, so I thought it appropriate to also bump the docker dotnet version.

This message answers everything! LGTM!

Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@curquiza
Copy link
Member

bors merge

@curquiza
Copy link
Member

bors broken again...

@curquiza curquiza merged commit fa89a5b into meilisearch:main Mar 30, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants