fix: Filter featured collection

mei23 · Dec 26, 2023 · 7d48f89 · 7d48f89
1 parent 78173e3
commit 7d48f89
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/packages/backend/src/server/activitypub/featured.ts b/packages/backend/src/server/activitypub/featured.ts
@@ -25,8 +25,9 @@ export default async (ctx: Router.RouterContext) => {
 		order: { id: 'DESC' },
 	});
 
-	const pinnedNotes = await Promise.all(pinings.map(pining =>
-		Notes.findOneByOrFail({ id: pining.noteId })));
+	const pinnedNotes = (await Promise.all(pinings.map(pining =>
+		Notes.findOneByOrFail({ id: pining.noteId }))))
+		.filter(note => !note.localOnly && ['public', 'home'].includes(note.visibility));
 
 	const renderedNotes = await Promise.all(pinnedNotes.map(note => renderNote(note)));
 

diff --git a/packages/backend/src/services/i/pin.ts b/packages/backend/src/services/i/pin.ts
@@ -45,7 +45,7 @@ export async function addPinned(user: { id: User['id']; host: User['host']; }, n
 	} as UserNotePining);
 
 	// Deliver to remote followers
-	if (Users.isLocalUser(user)) {
+	if (Users.isLocalUser(user) && !note.localOnly && ['public', 'home'].includes(note.visibility)) {
 		deliverPinnedChange(user.id, note.id, true);
 	}
 }
@@ -72,7 +72,7 @@ export async function removePinned(user: { id: User['id']; host: User['host']; }
 	});
 
 	// Deliver to remote followers
-	if (Users.isLocalUser(user)) {
+	if (Users.isLocalUser(user) && !note.localOnly && ['public', 'home'].includes(note.visibility)) {
 		deliverPinnedChange(user.id, noteId, false);
 	}
 }