Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable augmentations #61

Merged
merged 6 commits into from
Dec 8, 2023
Merged

Configurable augmentations #61

merged 6 commits into from
Dec 8, 2023

Conversation

ziw-liu
Copy link
Collaborator

@ziw-liu ziw-liu commented Nov 21, 2023

Made training-time augmentations configurable through YAML config files and CLI arguments.

One caveat is that the MONAI transforms has to be redefined so that the type hints in their __init__() signatures are supported by jsonargparse. This adds some boilerplate code in the library.

@ziw-liu ziw-liu added the enhancement New feature or request label Nov 21, 2023
@ziw-liu ziw-liu linked an issue Nov 21, 2023 that may be closed by this pull request
@ziw-liu
Copy link
Collaborator Author

ziw-liu commented Nov 22, 2023

Removed auto-generated notebooks since they are difficult to maintain and are duplicates of the python files.

@ziw-liu ziw-liu marked this pull request as ready for review November 22, 2023 18:54
Copy link
Contributor

@edyoshikun edyoshikun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than my comment. this LGTM! I also tested this with the newest mantis data model.

@ziw-liu ziw-liu merged commit 52d6291 into main Dec 8, 2023
3 checks passed
@ziw-liu ziw-liu deleted the configure-augmentation branch December 8, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

configurable augmentations
2 participants