Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package requirements #57

Merged
merged 8 commits into from
Feb 10, 2025
Merged

Update package requirements #57

merged 8 commits into from
Feb 10, 2025

Conversation

marcomangano
Copy link
Contributor

Purpose

This PR updates the minimum packages requirements and version of pyXDSM based on this GitHub issue

Expected time until merged

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@marcomangano marcomangano requested a review from a team as a code owner February 5, 2025 00:59
@marcomangano marcomangano requested a review from A-CGray February 5, 2025 00:59
@marcomangano
Copy link
Contributor Author

It looks like technically Numpy 1.21 does not support python 3.11? Probably on our docker images it works just fine, but in this action environment something in the wheel does not build correctly

@A-CGray
Copy link
Member

A-CGray commented Feb 7, 2025

We should probably just change the matrix to test numpy 1.21 with python 3.9 and numpy 1.25 with python 3.11, rather than all 4 combinations

@A-CGray
Copy link
Member

A-CGray commented Feb 7, 2025

@eirikurj looks like github is still requiring the python 3.8 flake8 check to pass, but we removed it here, I don't think I have the permissions to change the required checks, can you do it?

@eirikurj
Copy link
Contributor

eirikurj commented Feb 10, 2025

@A-CGray I have updated the requirements. Removed 3.8 and added 3.11. Feel free to merge it when ready.

@A-CGray A-CGray merged commit 97104ba into main Feb 10, 2025
8 checks passed
@A-CGray A-CGray deleted the marcomangano-patch-1 branch February 10, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants