-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update package requirements #57
Conversation
It looks like technically Numpy 1.21 does not support python 3.11? Probably on our docker images it works just fine, but in this action environment something in the wheel does not build correctly |
We should probably just change the matrix to test numpy 1.21 with python 3.9 and numpy 1.25 with python 3.11, rather than all 4 combinations |
@eirikurj looks like github is still requiring the python 3.8 flake8 check to pass, but we removed it here, I don't think I have the permissions to change the required checks, can you do it? |
@A-CGray I have updated the requirements. Removed 3.8 and added 3.11. Feel free to merge it when ready. |
Purpose
This PR updates the minimum packages requirements and version of pyXDSM based on this GitHub issue
Expected time until merged
Type of change
Testing
Checklist
flake8
andblack
to make sure the Python code adheres to PEP-8 and is consistently formattedfprettify
or C/C++ code withclang-format
as applicable