-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update testing matrix, start using image comparison #40
Conversation
Is there any world in which the reference images could be generated slightly differently on different operating systems or Python environment setups and cause these tests to fail? If I remember correctly, there have been cases when I've used matplotlib and gotten different results on different computers. |
Yeah, that's what the tolerance on the allowable fraction of different pixels is meant to handle. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, looks good to me then! My only request is to undo bumping the patch, because no lines in the source code have actually changed (the PyPI code will be identical).
I was bumping the version due to the changes in #39 , but I can put that in a separate PR if you want |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh ok, I didn't realize
Purpose
Update the versions of python, numpy and matplotlib we test against, now using python 3.9/10/11. For numpy and matplotlib I'm using both the latest release and the oldest supported release as listed here. This reduces the total number of CI jobs as we used to test against 3 versions of numpy.
Secondly, I was finally able to implement some parsing so that the image comparison checks I added in #30 only fail if the number of pixels that differ between images is > 0.05%, this should mean the test will only fail when there are actual meaningful differences between the images.
Expected time until merged
Type of change
Testing
Checklist
flake8
andblack
to make sure the Python code adheres to PEP-8 and is consistently formattedfprettify
or C/C++ code withclang-format
as applicable