Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): add classification to the pseudo-elements page #37670

Merged
merged 4 commits into from
Jan 24, 2025

Conversation

OnkarRuikar
Copy link
Contributor

The PR groups pseudo-elements as it is done on the pseudo-class page.

@OnkarRuikar OnkarRuikar requested review from a team as code owners January 16, 2025 05:58
@OnkarRuikar OnkarRuikar requested review from wbamberg and estelle and removed request for a team January 16, 2025 05:58
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed labels Jan 16, 2025
Copy link
Contributor

github-actions bot commented Jan 16, 2025

Preview URLs

Flaws (2)

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/CSSPseudoElement/type
Title: CSSPseudoElement: type property
Flaw count: 2

  • macros:
    • Can't resolve /en-US/docs/Web/API/Element/pseudo
    • Can't resolve /en-US/docs/Web/API/Element/pseudo

(comment last updated: 2025-01-24 20:50:48)

Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs work.

files/en-us/web/css/pseudo-elements/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/pseudo-elements/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/pseudo-elements/index.md Show resolved Hide resolved
files/en-us/web/css/pseudo-elements/index.md Outdated Show resolved Hide resolved
- : Represents the contents of the first line-box of the originating element.
- {{CSSxRef("::first-letter")}}
- : Represents the first letter, number, or symbol character on the first line of its originating element.
- {{CSSxRef("::slotted", "::slotted()")}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think slotted is in this category

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which category, then?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you moved it to element backed, which seems most appropriate.

files/en-us/web/css/pseudo-elements/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/pseudo-elements/index.md Outdated Show resolved Hide resolved
@wbamberg wbamberg removed their request for review January 22, 2025 22:41
@OnkarRuikar OnkarRuikar requested a review from estelle January 23, 2025 05:35
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic.thank you.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@estelle estelle merged commit e2819fa into mdn:main Jan 24, 2025
8 checks passed
@OnkarRuikar OnkarRuikar deleted the css_pseudoPage branch January 25, 2025 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List pseudo-elements by topic
2 participants