Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS module: box alignment #37566

Merged
merged 12 commits into from
Jan 15, 2025
Merged

CSS module: box alignment #37566

merged 12 commits into from
Jan 15, 2025

Conversation

estelle
Copy link
Member

@estelle estelle commented Jan 9, 2025

Updating the CSS box alignment module landing page.

  • updated the landing page.
  • reviewed the guides
  • moved guide content from landing page to an overview guide page.
  • updated links that went to the old landing page.

To maek the PR review process manageable:

fixes openwebdocs/project#215

@estelle estelle requested review from a team as code owners January 9, 2025 04:11
@estelle estelle requested review from pepelsbey and chrisdavidmills and removed request for a team January 9, 2025 04:11
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:SVG SVG docs Content:Glossary Glossary entries Content:Firefox Content in the Mozilla/Firefox subtree size/l [PR only] 501-1000 LoC changed labels Jan 9, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Preview URLs (9 pages)
Flaws (258)

Note! 3 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/CSS_box_alignment
Title: CSS box alignment
Flaw count: 57

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/Getting_started_with_the_web/CSS_basics
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps/What_is_CSS
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps/Getting_started
    • and 51 more flaws omitted
  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_box_alignment/Box_alignment

URL: /en-US/docs/Web/CSS/CSS_box_alignment/Box_alignment_in_flexbox
Title: Box alignment in flexbox
Flaw count: 49

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/Getting_started_with_the_web/CSS_basics
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps/What_is_CSS
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps/Getting_started
    • and 43 more flaws omitted
  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_box_alignment/Box_alignment

URL: /en-US/docs/Web/CSS/CSS_box_alignment/Box_alignment_in_block_abspos_tables
Title: Box alignment for block, absolutely positioned, and table layouts
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_box_alignment/Box_alignment

URL: /en-US/docs/Web/CSS/CSS_box_alignment/Box_alignment_in_grid_layout
Title: Box alignment in grid layout
Flaw count: 49

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/Getting_started_with_the_web/CSS_basics
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps/What_is_CSS
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps/Getting_started
    • and 43 more flaws omitted
  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_box_alignment/Box_alignment

URL: /en-US/docs/Web/CSS/CSS_box_alignment/box_alignment
Title: CSS box alignment overview
Flaw count: 53

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/Getting_started_with_the_web/CSS_basics
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps/What_is_CSS
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps/Getting_started
    • and 48 more flaws omitted

URL: /en-US/docs/Web/CSS/CSS_box_alignment/Box_alignment_in_multi-column_layout
Title: Box alignment in multi-column layout
Flaw count: 49

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/Getting_started_with_the_web/CSS_basics
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps/What_is_CSS
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/docs/Learn/CSS/First_steps/Getting_started
    • and 43 more flaws omitted
  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/CSS_box_alignment/Box_alignment
External URLs (1)

URL: /en-US/docs/Mozilla/Firefox/Releases/61
Title: Firefox 61 for developers

(comment last updated: 2025-01-15 18:19:05)

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estelle stellar work! I've left some comments for you to consider.

@@ -0,0 +1,292 @@
---
title: CSS box alignment
slug: Web/CSS/CSS_box_alignment/box_alignment
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This page makes sense, and it is structurally fine. However, calling the page the same as its parent page and having a slug of CSS_box_alignment/box_alignment seems redundant and a bit weird.

Calling the page "CSS box alignment overview" and having its slug as CSS_box_alignment/Overview (or similar) would make more sense, IMO.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The slug is still a bit odd, so flagging this again. If you feel strongly that it is not a problem, I'll leave it alone.

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @estelle. There are a couple of changes that I think would still be good to make, and I've commented those bits in my previous review, but I think it is up to you whether you want to tackle them now or leave them to a different PR.

I've also made a commit directly to your branch to fix a snafu I made in the text with one of my previous suggestions. Sorry about that!

Approving. Feel free to merge when ready.

@estelle estelle merged commit 49106bd into main Jan 15, 2025
10 checks passed
@estelle estelle deleted the cssmod-box-alignment branch January 15, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs Content:Firefox Content in the Mozilla/Firefox subtree Content:Glossary Glossary entries Content:SVG SVG docs size/l [PR only] 501-1000 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module landing page: CSS Box Alignment
2 participants