New pages: ShadowRoot.elementFromPoint() #37115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Content:WebAPI
|
Preview URLs (comment last updated: 2025-01-29 19:29:57) |
wbamberg
reviewed
Jan 8, 2025
Comment on lines
36
to
37
| let customElem = document.querySelector("my-custom-element"); | ||
| let shadow = customElem.shadowRoot; |
|
@estelle , since you have some comments from Hamish here I'll wait for them to be resolved before re-reviewing (otherwise things might get confusing). |
Co-authored-by: Hamish Willee <[email protected]>
Co-authored-by: Hamish Willee <[email protected]>
estelle
commented
Jan 23, 2025
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
| An {{domxref("Element")}}; the topmost shadow root element located at the specified coordinates, if any. | ||
|
|
||
| ## Examples | ||
|
|
There was a problem hiding this comment.
FYI it is now common, but not mandatory (AFAIK) to always have a descriptive level 3 heading as well as the main heading. This is a good thing to do, but up to you.
There was a problem hiding this comment.
the example is just a code example, not a rendered example. I generally add the subheading on live examples or when there are multiple. here is would be overkill.
Co-authored-by: Hamish Willee <[email protected]>
|
@wbamberg I think this is ready for re-review |
wbamberg
reviewed
Jan 29, 2025
wbamberg
reviewed
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of openwebdocs/project#214