-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simple Makefile autodetect for ARCH and BITS #312
Open
RBEGamer
wants to merge
1,881
commits into
mcostalba:master
Choose a base branch
from
official-stockfish:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seylab
approved these changes
Jun 9, 2021
chussana-pin
approved these changes
Nov 11, 2021
9173bb1
to
e0afedd
Compare
Passed STC: LLR: 2.93 (-2.94,2.94) <-1.75,0.25> Total: 40160 W: 10523 L: 10309 D: 19328 Ptnml(0-2): 129, 4543, 10524, 4753, 131 https://tests.stockfishchess.org/tests/view/6685ab8b99271ae49479dbe9 Passed LTC: LLR: 2.95 (-2.94,2.94) <-1.75,0.25> Total: 195672 W: 49681 L: 49639 D: 96352 Ptnml(0-2): 112, 20976, 55597, 21060, 91 https://tests.stockfishchess.org/tests/view/6686f27a7092ade1206f7889 closes #5445 No functional change
Fixes a missing default slot for dbg_extremes of, removes a extra newline, and updates SE elo estimate from https://tests.stockfishchess.org/tests/view/664ebd1e928b1fb18de4e4b7 while we are at it. closes #5446 No functional change
This is a revert of cc992e5. This patch is based on consistent observations that decreasing depth more in IIR generally has a bad scaling behaviour (good at STC, bad at longer time controls). Simplification STC: https://tests.stockfishchess.org/tests/view/6689266659cb3228a4759b26 LLR: 2.93 (-2.94,2.94) <-1.75,0.25> Total: 96992 W: 24977 L: 24824 D: 47191 Ptnml(0-2): 251, 11497, 24851, 11642, 255 Simplification LTC: https://tests.stockfishchess.org/tests/view/668930ffe59d990b103f6ab1 LLR: 2.95 (-2.94,2.94) <-1.75,0.25> Total: 35808 W: 9185 L: 8980 D: 17643 Ptnml(0-2): 25, 3776, 10101, 3973, 29 closes #5447 Bench: 1097766
This is a revert of 2046c92. This patch is based on the fact that the ttPv reduction has proven non-linear scaling (as documented in the code, along with testing guidelines); however, the original patch had (erroneously) not been tested at VLTC or longer. Simplification STC: https://tests.stockfishchess.org/tests/view/6689266e59cb3228a4759b28 LLR: 2.95 (-2.94,2.94) <-1.75,0.25> Total: 100320 W: 25913 L: 25763 D: 48644 Ptnml(0-2): 270, 11842, 25750, 12064, 234 Simplification LTC: https://tests.stockfishchess.org/tests/view/66893103e59d990b103f6ab3 LLR: 2.94 (-2.94,2.94) <-1.75,0.25> Total: 57078 W: 14466 L: 14282 D: 28330 Ptnml(0-2): 34, 6214, 15851, 6414, 26 closes #5448 Bench: 1124658
Using Singular Search Result Passed Non-regression STC: LLR: 3.01 (-2.94,2.94) <-1.75,0.25> Total: 62688 W: 16319 L: 16121 D: 30248 Ptnml(0-2): 196, 7317, 16104, 7547, 180 https://tests.stockfishchess.org/tests/view/66879bf51b527f04dd477ff9 Passed Non-regression LTC: LLR: 2.96 (-2.94,2.94) <-1.75,0.25> Total: 116502 W: 29504 L: 29379 D: 57619 Ptnml(0-2): 66, 12881, 32226, 13018, 60 https://tests.stockfishchess.org/tests/view/6688629e0c9d7c1ab33ed030 closes #5442 bench 1207930
dont let your memes be dreams !? Passed Non-regression STC: LLR: 2.95 (-2.94,2.94) <-1.75,0.25> Total: 512000 W: 132193 L: 132497 D: 247310 Ptnml(0-2): 1600, 61170, 130704, 60986, 1540 https://tests.stockfishchess.org/tests/view/66838911c4f539faa03268a2 Passed Non-regression LTC: LLR: 2.95 (-2.94,2.94) <-1.75,0.25> Total: 380268 W: 95894 L: 96042 D: 188332 Ptnml(0-2): 193, 42861, 104180, 42701, 199 https://tests.stockfishchess.org/tests/view/6688d0550c9d7c1ab33ed5a8 closes #5443 Bench: 1130282
Passed STC: LLR: 2.93 (-2.94,2.94) <0.00,2.00> Total: 328192 W: 84751 L: 84014 D: 159427 Ptnml(0-2): 758, 38802, 84253, 39511, 772 https://tests.stockfishchess.org/tests/view/6689203959cb3228a4759a49 Passed LTC: LLR: 2.95 (-2.94,2.94) <0.50,2.50> Total: 56748 W: 14494 L: 14136 D: 28118 Ptnml(0-2): 19, 6089, 15803, 6441, 22 https://tests.stockfishchess.org/tests/view/66892d76e59d990b103f6626 closes #5452 Bench 1253593
Passed non-regression STC: https://tests.stockfishchess.org/tests/view/668981d4df142e108ffc9bb4 LLR: 2.94 (-2.94,2.94) <-1.75,0.25> Total: 312672 W: 80280 L: 80363 D: 152029 Ptnml(0-2): 729, 37198, 80529, 37187, 693 Passed non-regression LTC: https://tests.stockfishchess.org/tests/view/668988c6df142e108ffca042 LLR: 2.95 (-2.94,2.94) <-1.75,0.25> Total: 126042 W: 31971 L: 31857 D: 62214 Ptnml(0-2): 50, 13988, 34832, 14100, 51 closes #5454 bench 1100483
This patch adjusts usage of previous statscore for bonus assginments - allowing it for any statscores and clamping it to wider range. Passed STC: https://tests.stockfishchess.org/tests/view/66892e76e59d990b103f6a91 LLR: 2.94 (-2.94,2.94) <0.00,2.00> Total: 431520 W: 111767 L: 110872 D: 208881 Ptnml(0-2): 1180, 51165, 110133, 52144, 1138 Passed LTC: https://tests.stockfishchess.org/tests/view/66897176e59d990b103f9605 LLR: 2.94 (-2.94,2.94) <0.50,2.50> Total: 143184 W: 36463 L: 35929 D: 70792 Ptnml(0-2): 55, 15540, 39863, 16084, 50 closes #5455 bench 1330556
Also removes unused arguments to update_all_stats to fix compiler warnings about unused parameters. Passed non-regression STC: https://tests.stockfishchess.org/tests/view/6689a79a0fdd852d63cf52e9 LLR: 2.94 (-2.94,2.94) <-1.75,0.25> Total: 26496 W: 6901 L: 6669 D: 12926 Ptnml(0-2): 62, 3094, 6715, 3304, 73 Passed non-regression LTC: https://tests.stockfishchess.org/tests/view/6689a9960fdd852d63cf532d LLR: 2.94 (-2.94,2.94) <-1.75,0.25> Total: 41214 W: 10373 L: 10173 D: 20668 Ptnml(0-2): 11, 4491, 11412, 4673, 20 closes #5456 bench 1169958
Created by setting output weights (256) and biases (8) of the previous main net nn-ddcfb9224cdb.nnue to values found around 12k / 120k spsa games at 120+1.2 This used modified fishtest dev workers to construct .nnue files from spsa params, then load them with EvalFile when running tests: https://github.com/linrock/fishtest/tree/spsa-file-modified-nnue/worker Inspired by researching loading spsa params from files: official-stockfish/fishtest#1926 Scripts for modifying nnue files and preparing params: https://github.com/linrock/nnue-pytorch/tree/no-gpu-modify-nnue spsa params: weights: [-127, 127], c_end = 6 biases: [-8192, 8192], c_end = 64 Example of reading output weights and biases from the previous main net using nnue-pytorch and printing spsa params in a format compatible with fishtest: ``` import features from serialize import NNUEReader feature_set = features.get_feature_set_from_name("HalfKAv2_hm") with open("nn-ddcfb9224cdb.nnue", "rb") as f: model = NNUEReader(f, feature_set).model c_end_weights = 6 c_end_biases = 64 for i in range(8): for j in range(32): value = round(int(model.layer_stacks.output.weight[i, j] * 600 * 16) / 127) print(f"oW[{i}][{j}],{value},-127,127,{c_end_weights},0.0020") for i in range(8): value = int(model.layer_stacks.output.bias[i] * 600 * 16) print(f"oB[{i}],{value},-8192,8192,{c_end_biases},0.0020") ``` For more info on spsa tuning params in nets: #5149 #5254 Passed STC: https://tests.stockfishchess.org/tests/view/66894d64e59d990b103f8a37 LLR: 2.94 (-2.94,2.94) <0.00,2.00> Total: 32000 W: 8443 L: 8137 D: 15420 Ptnml(0-2): 80, 3627, 8309, 3875, 109 Passed LTC: https://tests.stockfishchess.org/tests/view/6689668ce59d990b103f8b8b LLR: 2.94 (-2.94,2.94) <0.50,2.50> Total: 172176 W: 43822 L: 43225 D: 85129 Ptnml(0-2): 97, 18821, 47633, 19462, 75 closes #5459 bench 1120091
Based on recent simplification by linrock Since it completely removed any special bonuses based on values difference and made it flat stat_bonus(depth + 1) I got an idea that we might as well remove all (depth + 1) bonuses and make them usual depth bonuses. Also removes weird negative bonus for depth 1 as a side effect. Passed STC: https://tests.stockfishchess.org/tests/view/6689d817eca84f4d25863746 LLR: 2.94 (-2.94,2.94) <-1.75,0.25> Total: 18080 W: 4789 L: 4552 D: 8739 Ptnml(0-2): 46, 1987, 4727, 2244, 36 Passed LTC: https://tests.stockfishchess.org/tests/view/6689daa4eca84f4d258639d7 LLR: 2.95 (-2.94,2.94) <-1.75,0.25> Total: 109062 W: 27548 L: 27417 D: 54097 Ptnml(0-2): 58, 11983, 30293, 12164, 33 Passed direct LTC vs linrock patch: https://tests.stockfishchess.org/tests/view/668a46f8eca84f4d25866fe9 LLR: 2.95 (-2.94,2.94) <-1.75,0.25> Total: 100002 W: 25351 L: 25209 D: 49442 Ptnml(0-2): 54, 11119, 27529, 11229, 70 closes #5461 Bench 1175744
Always use the posix function posix_memalign() as aligned memory allocator on Apple computers. This should allow to compile Stockfish out of the box on all versions of Mac OS X. Patch tested on the following systems (apart from the CI) : • Mac OS 10.9.6 (arch x86-64-sse41-popcnt) with gcc-10 • Mac OS 10.13.6 (arch x86-64-bmi2) with gcc-10, gcc-14 and clang-11 • Mac OS 14.1.1 (arch apple-silicon) with clang-15 closes #5462 No functional change
Passed Non-regression STC: LLR: 2.94 (-2.94,2.94) <-1.75,0.25> Total: 74880 W: 19261 L: 19083 D: 36536 Ptnml(0-2): 202, 8861, 19120, 9071, 186 https://tests.stockfishchess.org/tests/view/668a0966eca84f4d25864cba Passed Non-regression LTC: LLR: 2.94 (-2.94,2.94) <-1.75,0.25> Total: 263916 W: 66690 L: 66718 D: 130508 Ptnml(0-2): 125, 29348, 73040, 29320, 125 https://tests.stockfishchess.org/tests/view/668a17e3eca84f4d25864e91 closes #5464 bench 1331408
Created by modifying L2 weights from the previous main net (nn-74f1d263ae9a.nnue) with params found by spsa around 9k / 120k games at 120+1.2. 370 spsa params - L2 weights in nn-74f1d263ae9a.nnue where |val| >= 50 A: 6000, alpha: 0.602, gamma: 0.101 weights: [-127, 127], c_end = 6 To print the spsa params with nnue-pytorch: ``` import features from serialize import NNUEReader feature_set = features.get_feature_set_from_name("HalfKAv2_hm") with open("nn-74f1d263ae9a.nnue", "rb") as f: model = NNUEReader(f, feature_set).model c_end = 6 for i in range(8): for j in range(32): for k in range(30): value = int(model.layer_stacks.l2.weight[32 * i + j, k] * 64) if abs(value) >= 50: print(f"twoW[{i}][{j}][{k}],{value},-127,127,{c_end},0.0020") ``` Among the 370 params, 229 weights were changed. avg change: 0.0961 ± 1.67 range: [-4, 3] The number of weights changed, grouped by layer stack index, shows more weights were modified in the lower piece count buckets: [54, 52, 29, 23, 22, 18, 14, 17] Found with the same method described in: #5459 Passed STC: https://tests.stockfishchess.org/tests/view/668aec9a58083e5fd88239e7 LLR: 3.00 (-2.94,2.94) <0.00,2.00> Total: 52384 W: 13569 L: 13226 D: 25589 Ptnml(0-2): 127, 6141, 13335, 6440, 149 Passed LTC: https://tests.stockfishchess.org/tests/view/668af50658083e5fd8823a0b LLR: 2.94 (-2.94,2.94) <0.50,2.50> Total: 46974 W: 12006 L: 11668 D: 23300 Ptnml(0-2): 25, 4992, 13121, 5318, 31 closes #5466 bench 1300471
In probcut move loop, everything is enclosed within a large if statement. I've changed it to guard clauses to stay consistent with other move loops. closes #5463 No functional change
closes #5470 No functional change
- Capitalize comments - Reformat multi-lines comments to equalize the widths of the lines - Try to keep the width of comments around 85 characters - Remove periods at the end of single-line comments closes #5469 No functional change
now uses the following format: `info string Found 510 WDL and 510 DTZ tablebase files (up to 6-man).` this clarifies exactly what has been found, as the difference matters, e.g. for the PV extension of TB scores. closes #5471 No functional change
STC with movepicker rewrite: LLR: 2.93 (-2.94,2.94) <-1.75,0.25> Total: 46656 W: 12208 L: 11995 D: 22453 Ptnml(0-2): 203, 5461, 11777, 5694, 193 https://tests.stockfishchess.org/tests/view/668d98a15034141ae5999e68 Earlier version passed STC: LLR: 2.94 (-2.94,2.94) <0.00,2.00> Total: 468896 W: 120999 L: 120054 D: 227843 Ptnml(0-2): 1207, 55209, 120639, 56218, 1175 https://tests.stockfishchess.org/tests/view/668b17d2cf91c430fca58630 Earlier version passed LTC: LLR: 2.94 (-2.94,2.94) <-1.75,0.25> Total: 550524 W: 139553 L: 139877 D: 271094 Ptnml(0-2): 333, 61646, 151616, 61346, 321 https://tests.stockfishchess.org/tests/view/668b2e04cf91c430fca586b1 closes #5472 bench 1234309 Co-authored-by: rn5f107s2 <[email protected]>
print `<empty>` and accept `<empty>` for UCI string options, accepting empty strings as well. Internally use empty strings (`""`). closes #5474 No functional change
Simplify away killer stage to a constant bonus given to the killer move during quiet move scoring. Passed Non-regression STC (Against then-pending PR #5472): LLR: 2.93 (-2.94,2.94) <-1.75,0.25> Total: 106176 W: 27685 L: 27539 D: 50952 Ptnml(0-2): 410, 12765, 26637, 12821, 455 https://tests.stockfishchess.org/tests/view/668dd0835034141ae5999e8f Passed Non-regression LTC: LLR: 2.95 (-2.94,2.94) <-1.75,0.25> Total: 92472 W: 23426 L: 23276 D: 45770 Ptnml(0-2): 55, 10376, 25215, 10544, 46 https://tests.stockfishchess.org/tests/view/669019e45034141ae5999fd2 closes #5476 Bench 1459677
Passed Non-regression STC: LLR: 2.94 (-2.94,2.94) <-1.75,0.25> Total: 168704 W: 43524 L: 43455 D: 81725 Ptnml(0-2): 414, 17173, 49076, 17308, 381 https://tests.stockfishchess.org/tests/view/66904b7b5034141ae599a197 Passed Non-regression LTC: LLR: 2.95 (-2.94,2.94) <-1.75,0.25> Total: 120294 W: 30473 L: 30364 D: 59457 Ptnml(0-2): 40, 10974, 38032, 11039, 62 https://tests.stockfishchess.org/tests/view/66905b235034141ae599a223 closes #5477 bench 1459677
Remove depth condition in propagation rule for ttPv state from a node to it childs. Because this change marks more nodes as ttPv, we have a time sensitive ttPv reduction rule and the STC snd LTC seems to show bad scaling. So i have also submitted a VLTC non-regression to check the scaling at higher time control. The results gives a little indication that we have perhaps good scaling with more ttPv nodes so that could be further explored. Passed non-regression STC: LLR: 2.95 (-2.94,2.94) <-1.75,0.25> Total: 82528 W: 21627 L: 21453 D: 39448 Ptnml(0-2): 317, 9809, 20891, 9877, 370 https://tests.stockfishchess.org/tests/view/678e608cd63764e34db49ad7 Passed non-regression LTC: LLR: 2.94 (-2.94,2.94) <-1.75,0.25> Total: 310440 W: 78879 L: 78956 D: 152605 Ptnml(0-2): 255, 34915, 84938, 34876, 236 https://tests.stockfishchess.org/tests/view/678fab89ac8f8f5496155f3c Passed non-regression VLTC for scaling verification: LLR: 2.95 (-2.94,2.94) <-1.75,0.25> Total: 59496 W: 15158 L: 14983 D: 29355 Ptnml(0-2): 15, 6039, 17470, 6204, 20 https://tests.stockfishchess.org/tests/view/6794bd1f4f7de645171fb33b closes #5819 Bench: 1829507
Replace the "low bestValue condition" with whether there is a best move. Passed Simplification STC LLR: 2.95 (-2.94,2.94) <-1.75,0.25> Total: 102560 W: 26517 L: 26367 D: 49676 Ptnml(0-2): 328, 12223, 26036, 12357, 336 https://tests.stockfishchess.org/tests/view/679310e4ca18a2c66da02af8 Passed Simplification LTC LLR: 2.95 (-2.94,2.94) <-1.75,0.25> Total: 66942 W: 17130 L: 16953 D: 32859 Ptnml(0-2): 52, 7459, 18290, 7600, 70 https://tests.stockfishchess.org/tests/view/679459a3e96bfb672ad18ddf closes #5820 Bench: 1438043
Passed STC: LLR: 2.94 (-2.94,2.94) <-1.75,0.25> Total: 235872 W: 61156 L: 61155 D: 113561 Ptnml(0-2): 843, 28269, 59658, 28376, 790 https://tests.stockfishchess.org/tests/view/6794dd3e4f7de645171fb380 Passed LTC: LLR: 2.94 (-2.94,2.94) <-1.75,0.25> Total: 61494 W: 15644 L: 15462 D: 30388 Ptnml(0-2): 61, 6822, 16788, 7026, 50 https://tests.stockfishchess.org/tests/view/6794f86a406a4efe9eb7d093 closes #5821 Bench: 2168937
Remove major correction history and slightly increase all other correction weights. Passed STC: LLR: 2.95 (-2.94,2.94) <-1.75,0.25> Total: 50080 W: 13171 L: 12959 D: 23950 Ptnml(0-2): 196, 5998, 12462, 6166, 218 https://tests.stockfishchess.org/tests/live_elo/67954526406a4efe9eb7d176 Passed LTC: LLR: 2.95 (-2.94,2.94) <-1.75,0.25> Total: 51504 W: 13188 L: 12995 D: 25321 Ptnml(0-2): 54, 5658, 14128, 5865, 47 https://tests.stockfishchess.org/tests/live_elo/67954961406a4efe9eb7d251 closes #5822 Bench: 2081366
Passed STC: https://tests.stockfishchess.org/tests/view/6794c4634f7de645171fb341 LLR: 2.95 (-2.94,2.94) <0.00,2.00> Total: 28096 W: 7412 L: 7106 D: 13578 Ptnml(0-2): 97, 3194, 7148, 3524, 85 Passed LTC: https://tests.stockfishchess.org/tests/view/6794ea13406a4efe9eb7d06b LLR: 2.95 (-2.94,2.94) <0.50,2.50> Total: 58086 W: 15049 L: 14684 D: 28353 Ptnml(0-2): 27, 6344, 15957, 6667, 48 closes #5823 Bench: 1711170
Passed simplification STC LLR: 2.97 (-2.94,2.94) <-1.75,0.25> Total: 155424 W: 40252 L: 40159 D: 75013 Ptnml(0-2): 511, 18655, 39328, 18666, 552 https://tests.stockfishchess.org/tests/view/6794084fe96bfb672ad18d90 Passed rebased simplification LTC LLR: 2.97 (-2.94,2.94) <-1.75,0.25> Total: 103944 W: 26567 L: 26427 D: 50950 Ptnml(0-2): 69, 11640, 28418, 11772, 73 https://tests.stockfishchess.org/tests/view/67955c9a406a4efe9eb7d7e4 closes #5825 Bench: 1839554
This PR updates the fastchess version used as part of the CI to the one used on fishtest, see official-stockfish/fishtest#2180. Also change the name/repo from fast-chess to fastchess. closes #5826 No functional change
…o a certain point No Ply Restriction in the condition that limits the depth extension to a certain point. Passed again LTC rebased: LLR: 2.95 (-2.94,2.94) <-1.75,0.25> Total: 195108 W: 49916 L: 49872 D: 95320 Ptnml(0-2): 170, 21846, 53464, 21918, 156 https://tests.stockfishchess.org/tests/view/6795542a406a4efe9eb7d361 closes #5824 Bench: 1767398
Passed Non-regression STC: LLR: 2.94 (-2.94,2.94) <-1.75,0.25> Total: 89056 W: 23225 L: 23067 D: 42764 Ptnml(0-2): 292, 9688, 24470, 9726, 352 https://tests.stockfishchess.org/tests/view/679816b2ae346be6da0ee8e7 closes #5830 Bench: 1767398
also prefetch a bit earlier while we're at it passed STC: https://tests.stockfishchess.org/tests/view/678c0860f4dc0a8b4ae8cf58 LLR: 2.95 (-2.94,2.94) <-1.75,0.25> Total: 67328 W: 17608 L: 17418 D: 32302 Ptnml(0-2): 256, 7905, 17156, 8087, 260 passed LTC: https://tests.stockfishchess.org/tests/view/678c1a56f4dc0a8b4ae8cfb1 LLR: 2.94 (-2.94,2.94) <-1.75,0.25> Total: 340896 W: 86577 L: 86685 D: 167634 Ptnml(0-2): 291, 38325, 93332, 38201, 299 closes #5831 Bench: 1910281
Make index of reduction consistent with rest of Stack closes #5832 No functional change
In line with previous experiments on improving scaling of IIR. Now it disables IIR for pv nodes with depth <= 2, so disallowing for it to perform a qsearch dive. Fixed games STC: https://tests.stockfishchess.org/tests/view/679ae6a951037ccaf3e30fb3 Elo: -10.36 ± 2.5 (95%) LOS: 0.0% Total: 20020 W: 4902 L: 5499 D: 9619 Ptnml(0-2): 128, 2653, 4976, 2194, 59 Passed VVLTC with STC bounds: https://tests.stockfishchess.org/tests/view/67954f2e406a4efe9eb7d266 LLR: 2.94 (-2.94,2.94) <0.00,2.00> Total: 196758 W: 50725 L: 50258 D: 95775 Ptnml(0-2): 21, 18153, 61564, 18620, 21 Passed VVLTC with LTC bounds: https://tests.stockfishchess.org/tests/view/6795a26bf6281b7d7b18698b LLR: 2.94 (-2.94,2.94) <0.50,2.50> Total: 323092 W: 83679 L: 82857 D: 156556 Ptnml(0-2): 48, 29475, 101659, 30335, 29 closes #5834 Bench: 3464332
Disable probcut check when we the ttValue is not at least probCutBeta, regardless of tt depth. Passed simplification STC LLR: 2.92 (-2.94,2.94) <-1.75,0.25> Total: 60896 W: 16030 L: 15835 D: 29031 Ptnml(0-2): 220, 7164, 15507, 7315, 242 https://tests.stockfishchess.org/tests/view/679c0a3251037ccaf3e3141e Passed simplification LTC LLR: 2.94 (-2.94,2.94) <-1.75,0.25> Total: 76644 W: 19557 L: 19392 D: 37695 Ptnml(0-2): 50, 8486, 21104, 8613, 69 https://tests.stockfishchess.org/tests/view/679c380b0774dfd78deaf35c closes #5840 Bench: 3543770
The values are taken from this tuning https://tests.stockfishchess.org/tests/view/679c4e150774dfd78deaf376 which added also a new material correction history. The full tune doesn't work but ignoring the new history results in this changes. Passed STC: LLR: 2.94 (-2.94,2.94) <0.00,2.00> Total: 102368 W: 27057 L: 26638 D: 48673 Ptnml(0-2): 394, 12031, 25949, 12382, 428 https://tests.stockfishchess.org/tess/view/679d2ca70774dfd78deaf796 Passed LTC: LLR: 2.96 (-2.94,2.94) <0.50,2.50> Total: 55044 W: 14215 L: 13855 D: 26974 Ptnml(0-2): 43, 5956, 15172, 6300, 51 https://tests.stockfishchess.org/tests/view/679d30be0774dfd78deafda2 closes #5841 Bench: 3068583
Passed Non-regression LTC: LLR: 2.96 (-2.94,2.94) <-1.75,0.25> Total: 95856 W: 24551 L: 24404 D: 46901 Ptnml(0-2): 85, 10621, 26364, 10778, 80 https://tests.stockfishchess.org/tests/view/679a9aedae346be6da0eebd6 Passed Non-regression VLTC: LLR: 2.95 (-2.94,2.94) <-1.75,0.25> Total: 157536 W: 40000 L: 39921 D: 77615 Ptnml(0-2): 43, 16416, 45775, 16487, 47 https://tests.stockfishchess.org/tests/view/679aed8f51037ccaf3e30fbf Passed Non-regression VVLTC: LLR: 2.94 (-2.94,2.94) <-1.75,0.25> Total: 51598 W: 13345 L: 13172 D: 25081 Ptnml(0-2): 0, 4735, 16162, 4896, 6 https://tests.stockfishchess.org/tests/view/679d368b0774dfd78deb0163 closes #5843 Bench: 2399312
Continuation of work done by @FauziAkram and @Viren6 They had a series of patches that decrease pruning for ttPv nodes - and it passed as a gainer at lower time controls while revert passed as a gainer at higher time controls. So it's a logical continuation of this work that increases pruning for ttPv nodes in hopes of scaling to longer TCs. Fixed games STC: https://tests.stockfishchess.org/tests/view/679ee3910774dfd78deb0efd Elo: -4.98 ± 2.1 (95%) LOS: 0.0% Total: 28584 W: 7229 L: 7639 D: 13716 Ptnml(0-2): 143, 3579, 7219, 3247, 104 nElo: -9.54 ± 4.0 (95%) PairsRatio: 0.90 Passed VVLTC with STC bounds: https://tests.stockfishchess.org/tests/view/679d21f70774dfd78deaf553 LLR: 2.94 (-2.94,2.94) <0.00,2.00> Total: 323282 W: 83729 L: 83105 D: 156448 Ptnml(0-2): 37, 29842, 101269, 30446, 47 Passed VVLTC with LTC bounds: https://tests.stockfishchess.org/tests/view/679e7a970774dfd78deb0cd3 LLR: 2.95 (-2.94,2.94) <0.50,2.50> Total: 113712 W: 29485 L: 29051 D: 55176 Ptnml(0-2): 13, 10376, 35640, 10818, 9 closes #5844 Bench: 2964045
No functional change
Passed STC: LLR: 2.95 (-2.94,2.94) <-1.75,0.25> Total: 42784 W: 11198 L: 10979 D: 20607 Ptnml(0-2): 166, 5024, 10822, 5185, 195 https://tests.stockfishchess.org/tests/view/6795b6f8f6281b7d7b1869d6 Failed LTC: LLR: -2.95 (-2.94,2.94) <-1.75,0.25> Total: 283614 W: 72046 L: 72587 D: 138981 Ptnml(0-2): 241, 32097, 77647, 31606, 216 https://tests.stockfishchess.org/tests/view/6795cbb6f6281b7d7b186a07 Passed VLTC: LLR: 2.94 (-2.94,2.94) <-1.75,0.25> Total: 59678 W: 15387 L: 15211 D: 29080 Ptnml(0-2): 23, 6169, 17273, 6357, 17 https://tests.stockfishchess.org/tests/view/6795c6dbf6281b7d7b1869f9 closes #5827 Bench: 3088494
This condition can never be true, it's superfluous. It never triggers even with a bench 16 1 20 run. To met the condition it would imply that the previous recapture was done by a higher rated piece than a Queen. This is only the case when the King recaptures and that's already handled in line 1161: (return (attackers & ~pieces(stm)) ? res ^ 1). closes #5839 No functional change
Passed Non-regression STC: LLR: 2.95 (-2.94,2.94) <-1.75,0.25> Total: 51232 W: 13560 L: 13351 D: 24321 Ptnml(0-2): 183, 6075, 12920, 6226, 212 https://tests.stockfishchess.org/tests/view/679d7b2b0774dfd78deb043f Passed Non-regression LTC (v. #5827): LLR: 2.94 (-2.94,2.94) <-1.75,0.25> Total: 172398 W: 44108 L: 44042 D: 84248 Ptnml(0-2): 122, 19207, 47489, 19245, 136 https://tests.stockfishchess.org/tests/view/679d7fb10774dfd78deb05d2 Passed Non-regression VLTC (v. #5827): LLR: 2.94 (-2.94,2.94) <-1.75,0.25> Total: 388540 W: 99314 L: 99464 D: 189762 Ptnml(0-2): 89, 40454, 113350, 40272, 105 https://tests.stockfishchess.org/tests/view/679da3be0774dfd78deb0ad4 closes #5846 Bench: 2688175
Now exits during startup. ``` ./stockfish Stockfish dev-20250202-243c7c6a by the Stockfish developers (see AUTHORS file) x1,5,0,10,0.5,0.0020 Option: "x1" was already added! ``` i.e. prevents and helps debug this case ```cpp int x1 = 5; TUNE(x1); TUNE(x1); ``` closes #5847 No functional change
Passed STC: https://tests.stockfishchess.org/tests/view/679f429e0774dfd78deb10a5 LLR: 2.95 (-2.94,2.94) <0.00,2.00> Total: 71584 W: 18905 L: 18529 D: 34150 Ptnml(0-2): 302, 8372, 18081, 8722, 315 Passed LTC: https://tests.stockfishchess.org/tests/view/679f72a00774dfd78deb1102 LLR: 2.94 (-2.94,2.94) <0.50,2.50> Total: 353952 W: 91007 L: 90024 D: 172921 Ptnml(0-2): 375, 39163, 96921, 40138, 379 closes #5848 Bench: 3642363
Passed STC: https://tests.stockfishchess.org/tests/view/679ea7bc0774dfd78deb0d68 LLR: 2.93 (-2.94,2.94) <-1.75,0.25> Total: 47680 W: 12575 L: 12364 D: 22741 Ptnml(0-2): 179, 5589, 12139, 5708, 225 Passed LTC: https://tests.stockfishchess.org/tests/view/679eb7760774dfd78deb0dbb LLR: 2.96 (-2.94,2.94) <-1.75,0.25> Total: 314220 W: 80110 L: 80189 D: 153921 Ptnml(0-2): 265, 35121, 86420, 35036, 268 closes #5849 Bench: 3161782
Based off [Simplify cutoffCnt](69be04d) commit Original [commit](kennethlee33@a77a895) adding extension condition seems to not be improving strength anymore Passed STC: LLR: 2.93 (-2.94,2.94) <-1.75,0.25> Total: 54176 W: 14331 L: 14125 D: 25720 Ptnml(0-2): 261, 6340, 13676, 6554, 257 https://tests.stockfishchess.org/tests/view/679edb7c0774dfd78deb0eed Passed LTC: LLR: 2.95 (-2.94,2.94) <-1.75,0.25> Total: 267198 W: 68148 L: 68179 D: 130871 Ptnml(0-2): 232, 30051, 73055, 30038, 223 https://tests.stockfishchess.org/tests/view/679ef2c70774dfd78deb0f43 closes #5851 Bench: 3119355
Move part of heuristic that makes reduction less before pruning stage. Passed STC: https://tests.stockfishchess.org/tests/view/679fdf1b0774dfd78deb13b3 LLR: 2.93 (-2.94,2.94) <0.00,2.00> Total: 47136 W: 12484 L: 12146 D: 22506 Ptnml(0-2): 211, 5472, 11866, 5806, 213 Passed LTC: https://tests.stockfishchess.org/tests/view/679fe6790774dfd78deb1753 LLR: 2.94 (-2.94,2.94) <0.50,2.50> Total: 100536 W: 25837 L: 25383 D: 49316 Ptnml(0-2): 103, 10990, 27622, 11456, 97 closes #5853 Bench: 3265587
Only increment when extension is less than 2 or it's a PvNode. Tested vs #5851. Failed STC: LLR: -2.97 (-2.94,2.94) <0.00,2.00> Total: 360064 W: 94546 L: 94271 D: 171247 Ptnml(0-2): 1835, 42826, 90314, 43343, 1714 https://tests.stockfishchess.org/tests/view/679f79cc0774dfd78deb1112 Passed LTC: LLR: 2.94 (-2.94,2.94) <0.00,2.00> Total: 443076 W: 113942 L: 113081 D: 216053 Ptnml(0-2): 480, 49076, 121579, 49909, 494 https://tests.stockfishchess.org/tests/view/679fa21b0774dfd78deb1178 Passed VLTC: LLR: 2.94 (-2.94,2.94) <0.50,2.50> Total: 187184 W: 48098 L: 47495 D: 91591 Ptnml(0-2): 59, 19036, 54792, 19653, 52 https://tests.stockfishchess.org/tests/view/679fb6000774dfd78deb11e8 closes #5855 Bench: 3018089
Some notes: - Both tests were conducted on top of #5848. - Based on tuning suggestions, the extension for capturing the previously moved piece was removed/simplified. (Developers can attempt to reintroduce it post-merge if needed.) - Initially, bonusScale = std::max(bonusScale, -2); was included but later removed in the second test upon Viz's request, however, it was nearly non-functional anyway. Passed VVLTC under STC bounds: LLR: 2.95 (-2.94,2.94) <0.00,2.00> Total: 31508 W: 8153 L: 7895 D: 15460 Ptnml(0-2): 1, 2747, 10005, 2995, 6 https://tests.stockfishchess.org/tests/view/679fdc7a0774dfd78deb1350 Passed VVLTC under LTC bounds: LLR: 2.94 (-2.94,2.94) <0.50,2.50> Total: 55026 W: 14370 L: 14046 D: 26610 Ptnml(0-2): 7, 4957, 17262, 5279, 8 https://tests.stockfishchess.org/tests/view/679fec920774dfd78deb19b8 closes #5856 Bench: 2757788
Continuation of work on scaling. In line with previous scaling patches this one massively reduces reduction for moves that don't go thru lmr for position without a tt move. Passed VVLTC with STC bounds: https://tests.stockfishchess.org/tests/view/679fd2450774dfd78deb12b2 LLR: 2.94 (-2.94,2.94) <0.00,2.00> Total: 74718 W: 19354 L: 19042 D: 36322 Ptnml(0-2): 5, 6724, 23595, 7024, 11 Passed VVLTC with LTC bounds: https://tests.stockfishchess.org/tests/view/67a009930774dfd78deb2346 LLR: 2.94 (-2.94,2.94) <0.50,2.50> Total: 82638 W: 21587 L: 21212 D: 39839 Ptnml(0-2): 15, 7476, 25953, 7869, 6 closes #5860 Bench: 2887850
Passed STC: https://tests.stockfishchess.org/tests/view/67a288aaeb183d11c65945f1 LLR: 2.99 (-2.94,2.94) <0.00,2.00> Total: 51424 W: 13588 L: 13237 D: 24599 Ptnml(0-2): 223, 6039, 12860, 6344, 246 Passed LTC: https://tests.stockfishchess.org/tests/view/67a28c0aeb183d11c6594609 LLR: 2.94 (-2.94,2.94) <0.50,2.50> Total: 54144 W: 13900 L: 13543 D: 26701 Ptnml(0-2): 42, 5881, 14870, 6236, 43 closes #5863 Bench: 2345723
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a simple autodetect flag for the makefile:
make build ARCH=autodetect
### 2.1.1 Simple Defaults Autodetection ifeq ($(ARCH),autodetect) arch = $(shell uname -m) bits = $(shell getconf LONG_BIT) endif
I used the modification in my docker build system.
Maybe its useful!