generate default constructors and manipulate storage after copying #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ivoysey
commented
Feb 25, 2022
•
ivoysey
commented
- generates default constructors for every object
- calls those constructors to build a copy of the main contract in memory at deployment time
- calls a copying tracer to migrate that to storage
- implements a convention on addresses to differentiate storage from memory
- subsequent transactions dynamically check pointers to read them from the right place
- added test cases
- updates to the testing harness to check for logs from both deployment and invocation
…yul from running solc, for local debugging
…r transaction names
… the contract name prefix
…saction names. this addresses #407
…he default constructor
…an actually use fold
…tion because this code alsp appears in the assignment case
…g them to std out in CI
…first address in storage, removing call to the tracer after new
…aring (x > threshold-1) so that we look in the right place for the first field in the first slot in storage
This was
linked to
issues
Mar 24, 2022
ivoysey
changed the title
mcoblenz
approved these changes
Mar 29, 2022
| @@ -9,6 +9,36 @@ object "{{contractName}}" { | |||
| code { | |||
| {{! init free memory pointer, see chatper "Layout in Memory" of the Solidity doc}} | |||
| {{memoryInit}} | |||
| {{! todo: these are copied from below }} | |||
There was a problem hiding this comment.
Not clear what is to be done. And where is below?
There was a problem hiding this comment.
I think there might be a way to give names to string in mustache, or else export the repeated chunk of code from the Scala call to the template so that it's not copied twice. I'll update the comment to make that possible fix more clear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.