cumulative updates from flat_alloc branch
#382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e flat yul object style (#367) * making a change to double check work flow * adding a stub for computing the size of a contract; that'll be its own PR entirely one day fairly soon, but for now, we assume that we just need 32 bytes * using hex values for some boilerplate so that it matches the docs * reworking constructors to just allocate memory * adding some helper functions in util. one is a renaming for transactions from child contracts; the other is basically a type-checked comment pointing out uses of some pretty substantian technical debt * temporarily removing the code to translate child contracts. rewriting the translation of Invocations to remap everything to local invocations instead, into the names that will be created in the flat yul object
* rename, add boolean for main-ness in translate decl * changing signature of translateDeclaration to remove a return that doesn't do anything * whitespace, scala style * comments * scraps; adding an assert * changing how child contracts are processed * rewrite of translateTransaction * chainging signature of translateStatement * more threading through inMain * whitespace, scala style * adding some docs * removing the nicer output for typed names in favor of a bland one, per solc's current limitations. adding a comment about why. * adding a temporary fix to the top of the dispatch table pending talking with MC" * removing a stale comment * comments * adding missing declarations to invocations * cleaning up comments and some messy logic around temporary variables * removing comment * more hacks for specific tests in advance of type info * changing hardcoded value in the mustache file for this to be the current contract address
* removing a util function to rename functions in the dispatch table; that no longer makes sense with the solution for flattening that we've settled on for now * adding comments; expanding getcontractname * ripping out some code, adding comments * adding a comment that may help to locate a bug later * moving comment closer to the source and updating it * comments * scraps; this change seemed likely but breaks a bunch of tests * quick function to traverse over an expression and check a given predicate on all the annotations * fixing some import dependencies * traversal of a program rather than just an expression; i sure hope i don't have to come back and make this the fully polymorphic map reduce but i bet i will * adding updates to the expression returned in the checker from just the ReferenceIdentifier cases, after some debugging with @mcoblenz * adding additional ParserUtil.updateExprType uses as seems right. bunch of tests fail, some of which i expected some i didn't, and i don't know how to fix a lot of them * updating width calculation to actually inspect the type, now that we know it * removing an assert that caused a bunch of false negatives. * small changes per PR comments
…o be edited down even more to be the right goal for a demo.
* copying a slightly cut down version of linked lists, but this needs to be edited down even more to be the right goal for a demo. * computing sizes of types recursively * adding some simple hard coded unit tests * copying over a helper from type checker tests to test on actual contracts in files * adding more general tests; it doesn't work but i think i know why * scraps and printlines from trying to debug sizes * changing the type of the size computation function so it has enough information, per MC. reworking tests * renaming size function; fixing the main test * adding some comments and a variable for pointer sizes * formatting, reworking base test * removing the two simpler unit tests. it is hard and somewhat pointless to be the parser and create a contract table by hand, the existing test is informative enough
* debugging scraps * copying a slightly cut down version of linked lists, but this needs to be edited down even more to be the right goal for a demo. * commenting out spammy prints * patch from MC * updating override syntax to not introduce a new field * updating expr type update to set the location and use the one field rather than build new ones * removing printlines * updating logged errors in a few places; this fixes some but not all of #379 * error in resourcesTest was in the test itself; it was incorrectly looking for m to be at int * formatting, whitespace * fixed permission passing test; also errors in the definition of the test, not the checker * fixing all permowned error * scala style, whitespace * scraps * adding a comment, removing a comment, removing an assert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flat_alloc branch is acting as a shadow master for #307. It's reached a semi-stable state now, so I'm opening this PR to merge the changes so far into master. I am not going to wait for a review of this PR, because each component change has been reviewed incrementally, nor will i remove the flat_alloc branch because that's still where I'm working.