Solidity State Corpus Study #295
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcoblenz
requested changes
Sep 7, 2020
|
|
||
|
|
||
| # This class is a detector plugin for Slither. It counts the number | ||
| # of states in each contract given to it, and if that number is more than |
| # of states in each contract given to it, and if that number is more than | ||
| class StateNum(AbstractDetector): | ||
| """ | ||
| Detect function named backdoor |
| return list(set(list1 + list2)) | ||
|
|
||
| # Takes in a list of indeces and a list of upper boundaries on those | ||
| # indeces and increments indeces in the index list until an index does |
| @@ -0,0 +1,2 @@ | |||
| To use these plugins with slither, first follow the instructions at https://github.com/crytic/slither/wiki/Developer-installation to set up the slither development environment. | |||
There was a problem hiding this comment.
pycache files appear to be derived binaries; remove them from the PR. You can add them to .gitignore.
|
|
||
| WIKI = 'STATE TEST' | ||
|
|
||
| WIKI_TITLE = 'TODO' |
| WIKI_RECOMMENDATION = 'This is just a check, it does not indicate an error' | ||
|
|
||
| # Checks if any contracts that contract inherits were already determined | ||
| # to be stateful. Returns the truth value of that check. |
There was a problem hiding this comment.
What if we haven't processed those contracts yet? Does Slither process in order of the inheritance hierarchy?
| # not reach its limit. After that happens, the rest of the input list is | ||
| # returned unchanged and the indeces that went over their limit are set | ||
| # to 0. If all elements go over their limits, None is returned instead. | ||
| def increment_list(self, index_list, length_list) : |
There was a problem hiding this comment.
I find this very confusing. Why is the third argument called "length_list"?
| # returned unchanged and the indeces that went over their limit are set | ||
| # to 0. If all elements go over their limits, None is returned instead. | ||
| def increment_list(self, index_list, length_list) : | ||
| new_indeces = [] |
There was a problem hiding this comment.
I think this whole thing might be easier to read in a functional style (with a map).
|
|
||
| # Checks whether or not a given check is stateful using the heuristic | ||
| # described in | ||
| # http://www.cs.cmu.edu/~aldrich/papers/aldrich-empirical-ecoop11.pdf |
There was a problem hiding this comment.
Say here what the heuristic is; I shouldn't have to go find it in the paper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch contains work from an unfinished corpus study done in Summer 2020.