Trusted Types: add tests for setAttributeNS with non-lowercase attributes with untrusted strings
#3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test that "credential" will be a DOMString turned out to be a failure because any Javascript object can be converted to the string "[Object object]". The referenced part of the specification isn't there any more. Bug: None Change-Id: Ie6a08a24f76e7a895517feef587ff31ecfe2fdac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5266622 Reviewed-by: Guido Urdaneta <[email protected]> Commit-Queue: Harald Alvestrand <[email protected]> Cr-Commit-Position: refs/heads/main@{#1256182}
Signed-off-by: syvb <[email protected]>
The only time we need hidden nodes is when they are part of a label or description. This CL keeps track of whether a given node has ever been part of a label or description. If the node is hidden, it removes it from the tree unless it's needed for a label/description. In combination with CL:4852390, which removes hidden line breaks, reduces the time spent in serialization and deserialization by massive amounts in tests that involve heavy usage of hidden subtrees. For the specific results, see: https://docs.google.com/spreadsheets/d/1ozLJMRT32yIxE0ja0rDhdZPb76hQtDd0klcRcR_uWYU/edit?pli=1#gid=0 This will make a significant difference in web apps with panels, chats, slides, etc. where a significant percentage of the content is hidden. Bug: 1448706, 1353788 Cq-Include-Trybots: luci.chromium.try:fuchsia-x64-accessibility-rel,linux-blink-web-tests-force-accessibility-rel Change-Id: I1b0de1d9b6f037c107efd3ca93c073382fd0ece1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4574033 Commit-Queue: Aaron Leventhal <[email protected]> Reviewed-by: Chris Harrelson <[email protected]> Cr-Commit-Position: refs/heads/main@{#1256230}
Checkboxes support validity via the required attribute and the other browsers support :user-valid/:user-invalid on them. The existing :user-valid/:user-invalid machinery only works on text fields, so this patch adds some code to checkboxes to make them work as well. Fixed: 1521781 Change-Id: I91309f36348470db5b1c706b519e6303e5deeab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5258739 Commit-Queue: Joey Arhar <[email protected]> Reviewed-by: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1256264}
As per spec, sourceURL / sourceFunctionName / sourceCharPosition Amended existing test. Bug: 1523675 Change-Id: Ic3bb8df05bb822fa8b56990e2696d67324b4763f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5250540 Reviewed-by: Ian Clelland <[email protected]> Reviewed-by: Rick Byers <[email protected]> Reviewed-by: Michal Mocny <[email protected]> Commit-Queue: Noam Rosenthal <[email protected]> Cr-Commit-Position: refs/heads/main@{#1256409}
This includes tests to confirm size/cols/rows are not presentational hints. Issue: whatwg/html#6807
…ercentages inside calc() in background-position longhands. See https://bugzilla.mozilla.org/show_bug.cgi?id=1874606#c3 (and the test is self-explanatory, it's just a copy of background-position-negative-percentage-comparison.html but with the longhand expanded). Differential Revision: https://phabricator.services.mozilla.com/D198532 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1874606 gecko-commit: c133f145c3444956eaacebff4066a0141a971af1 gecko-reviewers: layout-reviewers, jfkthame
This is kind of a wallpaper, but I think it's sound, read below. The reason this is asserting is that MathML in particular has some odd frame re-parenting going on (see nsCSSFrameConstructor::FlushAccumulatedBlock). That means that our assert in DepthOrderedFrameList is not really holding depending on when you add or remove the frame from the list. However this is not a problem in practice, at least for container queries, because anonymous frames that can wrap mathML cannot be containers themselves. I need to figure out what to do with that assert, but given it's useful for the other users of DepthOrderedFrameList, I think we should take this for now. Differential Revision: https://phabricator.services.mozilla.com/D200634 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1878188 gecko-commit: 7146c4efa63b2195fb331439048c4e1def420323 gecko-reviewers: fredw
…continueRequest Depends on D199749 Differential Revision: https://phabricator.services.mozilla.com/D199750 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1874206 gecko-commit: 2e55faaccd8265b6e48fb904d0104dc9ebdc6a84 gecko-reviewers: webdriver-reviewers, Sasha
…ontinueRequest Depends on D199750 Differential Revision: https://phabricator.services.mozilla.com/D199751 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1874206 gecko-commit: e088bd5cef05706254aac5844de407a74a2b3bd3 gecko-reviewers: webdriver-reviewers, Sasha
…continueResponse Depends on D199751 Differential Revision: https://phabricator.services.mozilla.com/D199752 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1874206 gecko-commit: 9636ddc3709af33bb67d228ea6022a8257c2d1b2 gecko-reviewers: webdriver-reviewers, Sasha
…ontinueResponse Depends on D199752 Differential Revision: https://phabricator.services.mozilla.com/D199753 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1874206 gecko-commit: cf600694c18f22e5cece13d493171124eff5d04d gecko-reviewers: webdriver-reviewers, Sasha
Depends on D199753 Differential Revision: https://phabricator.services.mozilla.com/D199754 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1874206 gecko-commit: c2eb34cf5007303cf4643d671d7be9e287d0e9b9 gecko-reviewers: webdriver-reviewers, Sasha
Depends on D199754 Differential Revision: https://phabricator.services.mozilla.com/D199755 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1874206 gecko-commit: 3884f0a38e09c6f16ef962a3b1db5623c659b4ff gecko-reviewers: webdriver-reviewers, Sasha
…network tests Depends on D199755 Adds test helpers to easily create header and cookie header objects Differential Revision: https://phabricator.services.mozilla.com/D200034 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1874206 gecko-commit: a3f956419067fa1803aa9210eb8252a3fc3daefa gecko-reviewers: whimboo, webdriver-reviewers
This removes `tentative` from Web Locks tests which all three engines are passing. A couple of exceptions from https://wpt.fyi/results/web-locks?label=experimental&label=master&aligned * clientids: The test follows the spec, I think this is a Chrome bug. (https://w3c.github.io/web-locks/#dom-lockmanager-request, the use of environment's id) * signal: A couple of WebKit failures because of lack of AbortSignal custom reason support. Differential Revision: https://phabricator.services.mozilla.com/D200477 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1878367 gecko-commit: 4235c5a3b4ac51348c29bfd3bf8e371b67b982c6 gecko-reviewers: smaug
Differential Revision: https://phabricator.services.mozilla.com/D200716 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1267079 gecko-commit: 391d1d3ba83e86e6535622a39119feb8f2b6a2f0 gecko-reviewers: emilio, TYLin
* Fix reflection tests wrt valueOf
Without a toString:null in test values that are objects
with a valueOf method, the DOM attribute would actually
be set to "[object Object]" without ever calling the
valueOf method (effectively turning those tests into
behaving exactly the same as the {"test": 6} ones).
Most existing tests were passing because the implemented
algorithms would actually compute a WRONG expected value.
The only test that doesn't compute the expected value
("double") won't actually run because all reflected IDL
attributes of type "double" have custom getters.
Fixes web-platform-tests#44315
* Fix reflection tests wrt -0 for "double" attributes
Setting -0 to the IDL attribute will set the DOM
attribute to "0" (per ECMAScript's ToString, from the
rules for the the best representation of a number as
a floating point number), and the rules for parsing
flowting-point number values won't ever turn that "0"
into a -0 value.
This test value is never actually being used though,
as all the reflected attributes of type "double" have
custom getters.
* Add a few more reflection tests around whitespace for numeric types
Specifically leading non-ASCII whitespace following leading
ASCII whitespace (should be rejected), and trailing non-ASCII
whitespace (should be ignored)
* Add a few more numeric values to reflection tests
Specifically "+" and "-" to exercise all possible code
paths of failures.
* Add exponential notation to reflection tests of double values
* Implement "limited double" in reflection tests
* Implement the reflect algorithm for doubles
This should make it easier to extend tests with more values.
An agreed upon proposal[1] by the CSS working group specifies that where multiple scroll snap targets are visually equally aligned, scroll containers should give priority to focused elements. Blink did this for programmatic scrolls but not for user scrolls. This patch prioritizes focused elements for both types of scrolls by relying on a bit in SnapAreaData. [1]w3c/csswg-drafts#9622 Bug: 1523819 Change-Id: I81e2aaf0845e9763abb463a960614beb37b05a8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5255777 Reviewed-by: Steve Kobes <[email protected]> Commit-Queue: David Awogbemila <[email protected]> Cr-Commit-Position: refs/heads/main@{#1256790}
…ver_util.py The CORS logic present in direct-from-seller-signals.py is identical to that needed for other web platform tests. Moving this logic into a common function available to the endpoints needed for those other web platform tests prevents duplication. This change also attempts to match the style of the Python test server in new and existing code. Change-Id: Ia3db1e263e3e4b1e6b09bfa3408dd905a83ea44b Bug: 40275797 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5269747 Commit-Queue: Orr Bernstein <[email protected]> Reviewed-by: Matt Menke <[email protected]> Cr-Commit-Position: refs/heads/main@{#1256845}
… interface Explainer PR: WICG/shared-storage#130 Bug: 1218540 Change-Id: I7dffe4e026a6ebf4e6705b1df43e2baf01dadb12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5209512 Commit-Queue: Yao Xiao <[email protected]> Reviewed-by: Dominic Farolino <[email protected]> Reviewed-by: Cammie Smith Barnes <[email protected]> Cr-Commit-Position: refs/heads/main@{#1256903}
The referring URL as computed by the referrer policy for the prefetch request was incorrectly being used to determine whether a prefetch was cross site. This value is only meant to be used for the prefetch request. The omission of the URL made it look like a cross site prefetch, so the cookie eligibility check was applied. We now use the initiating origin to determine whether a prefetch is cross site. Bug: 1524338 Change-Id: Id154effae55c539fff7cd733327fc9029c53b03a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5263133 Commit-Queue: Kevin McNee <[email protected]> Reviewed-by: Liviu Tinta <[email protected]> Cr-Commit-Position: refs/heads/main@{#1256905}
This change adds support to observe out of viewport targets inside scrollable same origin iframes using intersection observers with scrollMargin, by crossing the iframe boundary when collecting intermediate scrollers. R=szager Bug: 1503290 Change-Id: Iaf5482a67e8eb37000d54fb9529df5c16f86e644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5240906 Reviewed-by: Stefan Zager <[email protected]> Commit-Queue: Traian Captan <[email protected]> Cr-Commit-Position: refs/heads/main@{#1256994}
Now that the HTML parser allows <button> and <datalist> in <select>, this patch modifies the UA shadowroot of <select> to slot the <button> and <datalist> and render them. If a <button> is provided with no <datalist>, then the native popup is used. If a <datalist> is provided with no <button>, then the native button is used. Bug: 1511354 Change-Id: I36f88f73949aa2cba502231ed2d68c1738e47946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5230929 Auto-Submit: Joey Arhar <[email protected]> Reviewed-by: Mason Freed <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1257004}
Declarative shadow DOM is standard [1] and implemented in all modern browsers. This removes a polyfill that isn't needed in WPT any longer. [1] https://html.spec.whatwg.org/multipage/scripting.html#attr-template-shadowrootmode Bug: N/A Change-Id: Ie9bfdf24f75901cf9a476844a76065e5a18a6815 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5263643 Auto-Submit: Mason Freed <[email protected]> Reviewed-by: Joey Arhar <[email protected]> Commit-Queue: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1257013}
…eb-platform-tests#44424) This allows vendors to override expectations at runtime via browser-specific result converters. Instead of constructing `(Subtest)Result`s directly, executors should use the newly introduced `Test.make_{subtest_,}result()`, which have the same signatures but default to passing through the testloader-read expectations. This is a pure refactor; no functional changes intended. Successor to: web-platform-tests#44134 (comment)
This CL migrate Web Serial MojsJS based tests to internal folder temporary. We will move it back once Web Serial Testing specification for test-only interface is defined. Bug: 1524403 Change-Id: I75323dfe2a649348e23c333e1a635cf8cc9ba806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5259047 Reviewed-by: Matt Reynolds <[email protected]> Commit-Queue: Alvin Ji <[email protected]> Reviewed-by: Alvin Ji <[email protected]> Cr-Commit-Position: refs/heads/main@{#1257126}
…rContext Depends on D200019 Differential Revision: https://phabricator.services.mozilla.com/D200023 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1874918 gecko-commit: 9958e50aa342f1417ae85b1ceed8a11d5864d521 gecko-reviewers: webdriver-reviewers, Sasha
See whatwg/html#10150. Per spec these run even if the attribute doesn't change. Differential Revision: https://phabricator.services.mozilla.com/D202240 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1881075 gecko-commit: 2c4646b33c7313f86fb6fb60be42fb5fcb5f106b gecko-reviewers: zsun
To confirm that SharedWorker blob URL inherits the ServiceWorker controller, this CL adds a WPT to confirm that. Note that we know that Chromium does not pass this test due to crbug.com/40364838. Bug: 324939068 Change-Id: Ief9e00eb798eb446f299910a1403651a86c7950c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5312920 Reviewed-by: Hiroki Nakagawa <[email protected]> Commit-Queue: Yoshisato Yanagisawa <[email protected]> Cr-Commit-Position: refs/heads/main@{#1263190}
Bumps [selenium](https://github.com/SeleniumHQ/Selenium) from 4.14.0 to 4.18.1. - [Release notes](https://github.com/SeleniumHQ/Selenium/releases) - [Commits](SeleniumHQ/selenium@selenium-4.14.0...selenium-4.18.1) --- updated-dependencies: - dependency-name: selenium dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
All tests that previously relied on generic_sensor_mocks.js have now been updated to use WebDriver, making generic_sensor_mocks.js obsolete. Bug: 1278377, 1520919 Change-Id: I50deb52438d63ffb6c2c0c603a7ec7b0f5fb71f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5307823 Reviewed-by: Raphael Kubo Da Costa <[email protected]> Reviewed-by: Gregory Guterman <[email protected]> Commit-Queue: Gregory Guterman <[email protected]> Auto-Submit: Juha J Vainio <[email protected]> Cr-Commit-Position: refs/heads/main@{#1262748}
This changeset adds tests for cached resources which will hit the http cache. It also adds a basic test for cached requests for the beforeRequestSent event, which was missing. Differential Revision: https://phabricator.services.mozilla.com/D201203 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1879502 gecko-commit: 529c62e247fb8c6e5afba57cee5c359f5b062728 gecko-reviewers: webdriver-reviewers, Sasha
Implements web-platform-tests/rfcs#133. Differential Revision: https://phabricator.services.mozilla.com/D200470 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1878347 gecko-commit: 400fd14b708738816caa78c5be9bec9f9aaf4705 gecko-reviewers: jgraham
Differential Revision: https://phabricator.services.mozilla.com/D202163 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1880859 gecko-commit: f9f3f34a88396f07c5821dc9304fdc8a096d5054 gecko-reviewers: webdriver-reviewers, whimboo
Differential Revision: https://phabricator.services.mozilla.com/D202073 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1822171 gecko-commit: 577745e56c0253db013c729f4f0d54b24ebea00b gecko-reviewers: geckoview-reviewers, m_kato
Differential Revision: https://phabricator.services.mozilla.com/D202074 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1822171 gecko-commit: 072153b2a9fee10e7f68921be3ca188a827f90b9 gecko-reviewers: geckoview-reviewers, m_kato
asserting what was said in the note that was removed as redundant with JSEP: w3c/webrtc-pc#2941 BUG=None Change-Id: I6ed59532788ef7bd2a3e3a9ae17c40076b39f747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5310061 Commit-Queue: Philipp Hancke <[email protected]> Reviewed-by: Florent Castelli <[email protected]> Cr-Commit-Position: refs/heads/main@{#1263260}
This will disable mutation events for all tests. This CL adds a virtual suite that continues testing with mutation events enabled, but it also disables a number of tests except for within that virtual suite. Bug: 40268638 Change-Id: I346fb1524d6f6143804678305ba3316bfa64095f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4550247 Reviewed-by: Bo Liu <[email protected]> Commit-Queue: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1263414}
We don't want to be doing anything on the single-threaded section ideally, so defer the TLS handshake until we're on a thread.
In https://crrev.com/c/5249795 orientation-event web tests where changed to use WebDriver. After change tests which where failing do not fail anymore. This enables us to remove orientation-event test from test expectation lists. In https://crrev.com/c/2154389, the usage of setTimeout in orientation-event-helpers.js was removed, allowing us to remove the file from the lint ignore list. Bug: 1520919 Change-Id: I67be0a834fa87686f36aedc617fbca57dc23c842 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5309923 Reviewed-by: Reilly Grant <[email protected]> Auto-Submit: Juha J Vainio <[email protected]> Commit-Queue: Reilly Grant <[email protected]> Reviewed-by: Raphael Kubo Da Costa <[email protected]> Cr-Commit-Position: refs/heads/main@{#1263426}
The change allows single moov box even with live mode, no duration data and no random access box. Bug: 41496328 Change-Id: I5dc5e80d8b4e0181b9257dfa1dac03c99cde0597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5311091 Commit-Queue: Sunggook Chue <[email protected]> Reviewed-by: Dale Curtis <[email protected]> Reviewed-by: Markus Handell <[email protected]> Cr-Commit-Position: refs/heads/main@{#1263512}
To increase developer ergonomics, we drop the limit on number of key-value pairs per origin, as well as the previous character limits for keys and values. We move instead to a total byte quota for each origin. Note that, strictly speaking, there will still a key and value length limit, in that each key and value must necessarily be less than or equal to the quota, given that the total of all lengths of keys and values must not exceed the quota. We accomplish this by updating the previous feature param `blink::features::kMaxSharedStorageEntriesPerOrigin` to a new feature param `blink::features::kMaxSharedStorageBytesPerOrigin`, deleting the previous feature param `blink::features::kMaxSharedStorageStringLength`, and replacing instances of the later with half of the new value for `blink::features::kMaxSharedStorageBytesPerOrigin` (as we are measuring the length in number of char16_t's). For more information, see WICG/shared-storage#132. Bug: 325352528,1218540 Change-Id: Icf3c390fcdb2893e74d1112c53db0ece2ecefe7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5296983 Reviewed-by: Dominic Farolino <[email protected]> Reviewed-by: Yao Xiao <[email protected]> Reviewed-by: Russ Hamilton <[email protected]> Commit-Queue: Cammie Smith Barnes <[email protected]> Cr-Commit-Position: refs/heads/main@{#1263539}
This CL "fixes" Observable unsubscription/teardown timing. As a matter
of accidental historical precedent, Observables in JavaScript (but not
in other languages) had implemented the "rule" that upon
Subscriber#error() or Subscriber#complete(), the subscriber would:
1. First, invoke the appropriate Observer callback, if provided (i.e.,
complete() or error() callback).
2. Signal abort Subscriber#signal, which invokes any teardowns and also
fires the `abort` event at the signal.
However, after [email protected] discussed this more with
[email protected], we came to the conclusion that the principle of "as
soon as you know you will teardown, you MUST close the subscription and
any upstream subscriptions" should be adhered. This means the above
steps must be inverted. This is a small-in-size but medium-in-impact
design change for the Observable concept, and led to a blog post [1] and
an announcement [2] that the RxJS library intends to change its
historical ordering of these events.
This CL:
1. Inverts the order of the aforementioned steps in the Blink
implementation.
2. Improves some tests that assert this new ordering.
3. Simplifies the takeUntil() operator in general.
The Observable spec will be updated alongside this commit:
WICG/observable#120.
[1]: https://benlesh.com/posts/observables-are-broken-and-so-is-javascript/
[2]: ReactiveX/rxjs#7443
[email protected]
Bug: 1485981
Change-Id: I376e66eef490808d264dc999862a801d591aa278
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5311097
Commit-Queue: Dominic Farolino <[email protected]>
Reviewed-by: Mason Freed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1263562}
This test caught a subtle bug in one of the versions of my previous patch, but it caught it by chance. The reason it got caught is because the reftest harness uses a mutation observer, and thus disables the textContent optimization that reuses the text node. WPT didn't catch this, so move the test there, and add tests for the characterData mutation and removal-and-append explicitly, to not depend on textContent optimizations. Differential Revision: https://phabricator.services.mozilla.com/D202230 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1874040 gecko-commit: 4ce4c83e0d85795f8566bedccf327bd780bad30f gecko-reviewers: smaug
Differential Revision: https://phabricator.services.mozilla.com/D201730 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1880046 gecko-commit: 482c70c1af04102f7a3965b75a1989ef1ec9ceca gecko-reviewers: fredw, smaug
This patch also adds some basic wpt tests for the button flow. Bug: 326091153 Change-Id: I5df924a3f82bb45b27e8ff580037433b7585af88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5310541 Commit-Queue: Yi Gu <[email protected]> Reviewed-by: Christian Biesinger <[email protected]> Cr-Commit-Position: refs/heads/main@{#1263621}
This CL implements the semantics specified in https://wicg.github.io/observable/#dom-observable-map. See WICG/observable#110. For WPTs: Co-authored-by: [email protected] [email protected] Bug: 40282760 Change-Id: I2e77374d568d60908c049c763efb3e23214ed14a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5281477 Commit-Queue: Dominic Farolino <[email protected]> Reviewed-by: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1263631}
This CL implements the semantics specified in https://wicg.github.io/observable/#dom-observable-filter. See WICG/observable#112. For WPTs: Co-authored-by: [email protected] [email protected] Bug: 40282760 Change-Id: I507cd7bd4117e81e718bb31e496cc4b763d9570a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5280443 Commit-Queue: Dominic Farolino <[email protected]> Reviewed-by: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1263643}
…#44716) `mozlog` allows `process_output` events to be interspersed between any `test_*` events [0]. When running tests in parallel, there's currently no structured way to tell which test a `process_event` corresponds to, which prevents us from extracting per-test browser logs. (The required `pid` field is unhelpfully that of the main `testrunner` process.) Log the browser PID during `test_end` as `extra.browser_pid` so that it can be joined against `process_output`'s `process` field. [0]: https://firefox-source-docs.mozilla.org/mozbase/mozlog.html#testsuite-protocol
Differential Revision: https://phabricator.services.mozilla.com/D193124 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1811912 gecko-commit: f743d6b74f6026f076f6519c6ca6ef8659a2d0ac gecko-reviewers: jib
…n element namespace and an attribute namespace Preparation to implement the tests. See the next commits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the last tests mentioned at w3c/trusted-types#425 (comment).