Skip to content

Conversation

@EraYaN
Copy link

@EraYaN EraYaN commented Dec 6, 2018

Tracking some changes here.

Added more options to for mode unparsing.
Added support for NameConstants.
Added support for Byte strings (and also chars as single byte strings).
@mbdevpl
Copy link
Owner

mbdevpl commented Feb 25, 2019

Hey! Just FYI: I've been also working on the C++ unparser in the meantime - although changes are not in master yet. I'd definitely like to merge the efforts at some point ;)

@EraYaN
Copy link
Author

EraYaN commented Feb 28, 2019

Right my main blocker is the fact that an and gets output because it uses the basic unparser from horast for expressions. While not all compilers support this (MSVC for example). Although you can get it with a header include, and that works, it's not truly proper IMO. But I also couldn't bring myself to go and re implement all the unparsing logic for expressions.

The branch name is misleading at this time, since I only touched the C++ unparser. Also I saw that python 3 supports syntax with a * in front of a variable. So that could then be mapped to the same operator in C++.

But most of all, I'm just trying to make stuff work. (like char literals are bytes objects that happen to be one character.)

@EraYaN EraYaN mentioned this pull request Jun 13, 2019
@EraYaN
Copy link
Author

EraYaN commented Jun 13, 2019

Closed in favour of #8

@EraYaN EraYaN closed this Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants