Skip to content

Feature/cli submit block #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Conversation

maxrobot
Copy link
Owner

This is the last submission in this location please refer to Ion Stage 2 for future development :'(

maxrobot and others added 18 commits June 18, 2018 15:41

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.
…ted my will to live/code

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Feature/rpc calls

Unverified

This user has not yet uploaded their public signing key.
…nikio

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.
…now blocks can be faked off-chain by real validators :)

Unverified

This user has not yet uploaded their public signing key.
…ract revert more sexily but oh well for now

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.
@maxrobot maxrobot self-assigned this Jun 25, 2018
@HarryR
Copy link

HarryR commented Jun 25, 2018

I can't build the go project.

$ make run
main.go:10:2: cannot find package "github.com/validation/src/cli" in any of:
	/usr/lib/golang/src/github.com/validation/src/cli (from $GOROOT)
	/home/user/go/src/github.com/validation/src/cli (from $GOPATH)
main.go:11:2: cannot find package "github.com/validation/src/config" in any of:
	/usr/lib/golang/src/github.com/validation/src/config (from $GOROOT)
	/home/user/go/src/github.com/validation/src/config (from $GOPATH)
make: *** [Makefile:23: run] Error 1

When I change imports to relative (e.g. ./config instead of github.../validation/src/config) it gives me another error.

$ GOPATH=`pwd` go build
# _/home/user/github.com/HarryR/ion/src
./main.go:20: setup declared and not used

How can I make the Makefile build the thing regardless of which directory it's in? I just wanna be able to type make and then a ion-cli tool appears soon after.

Also:

$ go get github.com/maxrobot/validation
package github.com/maxrobot/validation: no buildable Go source files in /home/user/go/src/github.com/maxrobot/validation

When I run this I get a different error:

$ go get github.com/maxrobot/validation/src
# cd .; git clone https://github.com/validation/src /home/user/go/src/github.com/validation/src
Cloning into '/home/user/go/src/github.com/validation/src'...
remote: Repository not found.
fatal: repository 'https://github.com/validation/src/' not found
package github.com/validation/src/cli: exit status 128
package github.com/validation/src/config: cannot find package "github.com/validation/src/config" in any of:
	/usr/lib/golang/src/github.com/validation/src/config (from $GOROOT)
	/home/user/go/src/github.com/validation/src/config (from $GOPATH)

@maxrobot
Copy link
Owner Author

maxrobot commented Jun 25, 2018

Have you cloned the repo into $GO_ROOT/src/github.com ?

The way I envision it's used is you make from the src directory.

Just looking into the problems you are having :)

@HarryR
Copy link

HarryR commented Jun 25, 2018

i tries 'go install' but thag didnt work, which would have put it in the right place, so i checked out to my normal place and tried to run the makefile, but that failed.

can you try adding a travis CI file and set the language to 'go' and see what Travis does when building? if not i can gice it a go when i get back from lunch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants