Expand email alias domain lists - #683
Conversation
Add fastmail.ca to the Fastmail domain set and myyahoo.com to the Yahoo domain set, so more equivalent addresses normalize to the same value before hashing. Both are confirmed to run on their provider's own mail platform with no third-party migration history.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe email domain allowlists now include ChangesEmail normalization
Estimated code review effort: 1 (Trivial) | ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Adds two newly identified alias domains so more equivalent addresses
normalize to the same value before hashing:
fastmail.ca— Fastmail's own Canadian domain. Confirmed via MXrecords resolving to Fastmail's
messagingengine.cominfrastructure,and listed on Fastmail's official domain list.
myyahoo.com— an alternate Yahoo-owned signup domain (WHOISregistrant: Yahoo Assets LLC), functionally identical to yahoo.com.
Both run on their provider's own native mail platform with no
third-party migration history, so the existing normalization logic
applies to them exactly as it does to their canonical counterparts.
This mirrors the same addition made to the minFraud web service's own
email normalization.
Testing
Added matching unit test cases following the existing pattern. Not run
locally — no Maven available in this environment — so CI should be
checked before merge.
🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Bug Fixes