fix: Changed empty files sent in addDatasetEntries from [] to { "files" : []}

[AryanDesh]

fix: Changed empty files sent in addDatasetEntries from [] to { "files" : []}

[coderabbitai]

📝 Walkthrough

Summary by CodeRabbit

• Bug Fixes

  • Corrects handling of empty file attachments when adding dataset entries. Empty file cells are now recognized as files with no attachments, preventing errors and ensuring consistent processing across the app.

• Documentation

  • Adds a changelog entry for v6.16.1 describing the fix.

• Chores

  • Bumps version to 6.16.1.

Walkthrough

Version bumped to 6.16.1. Documentation adds a changelog entry describing a fix in addDatasetEntries for file-type cells. Implementation updates dataset API transformation to send empty file cells as { "files": [] } instead of [].

Changes

Cohort / File(s)	Summary of Changes
Documentation README.md	Added v6.16.1 changelog entries noting the empty file payload adjustment in addDatasetEntries.
Versioning package.json	Updated version from 6.16.0 to 6.16.1.
Dataset API Logic src/lib/apis/dataset.ts	In MaximDatasetAPI.addDatasetEntries, empty file-type cell values now serialize as { "files": [] } instead of []; non-file handling unchanged.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Client
  participant API as MaximDatasetAPI
  participant Backend

  Client->>API: addDatasetEntries(entries)
  Note over API: Transform entries
  rect rgba(200,230,255,0.3)
    alt file-type cell
      API->>API: Map empty to value = { files: [] }  (was [])
    else non-file cell
      API->>API: Use entry.cellValue.payload
    end
  end
  API->>Backend: POST /datasets/{id}/entries (transformed payload)
  Backend-->>API: 200 OK
  API-->>Client: Result

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I thump my paw—version hop, neat and clean,
From empty [] to files: []—now seen.
Docs tell the tale, a tidy delight,
API packs payloads proper and right.
With ears up high, I merge and preen—
6.16.1, so crisp, so keen! 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title clearly and specifically describes the primary change—switching the empty-file payload sent by addDatasetEntries from [] to { "files": [] }—which matches the code change in src/lib/apis/dataset.ts and the README entry. It is a concise single sentence focused on the main change.
Description Check	✅ Passed	The PR description restates the same specific change as the title and directly relates to the modifications in src/lib/apis/dataset.ts and README, so it satisfies the lenient relevance requirement. Although brief, it is on-topic and describes the change.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch 09-24-fix_changed_empty_files_sent_in_adddatasetentries_from_to_files_

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6ccdef8 and b8260a6.

📒 Files selected for processing (3)

• README.md (1 hunks)
• package.json (1 hunks)
• src/lib/apis/dataset.ts (1 hunks)

🔇 Additional comments (4)

package.json (1)

4-4: LGTM! Version bump matches the PR objective.

The version bump from 6.16.0 to 6.16.1 correctly reflects the patch-level fix described in the PR objectives.

src/lib/apis/dataset.ts (2)

37-37: LGTM! File entry payload structure standardization.

The change from [] to { "files": [] } for file-type entries creates a consistent API payload structure that better represents the semantic intent of empty file collections.

---

24-87: Verify downstream consumers accept { "files": [] } for new file entries

Code now sends value: { "files": [] } on create (src/lib/apis/dataset.ts:34–38 / src/lib/apis/dataset.ts:37); internal types/tests use payload: Attachment[] (src/lib/models/dataset.ts:51–53, src/lib/dataset.test.ts:127–132). No other usages of a files object were found — confirm backend/clients accept the new shape or revert to sending an empty array to avoid breaking changes.

README.md (1)

480-483: LGTM! Changelog accurately documents the fix.

The changelog entry correctly describes the change from [] to { "files": [] } for empty files in addDatasetEntries, providing clear documentation for users about the payload structure modification.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[AryanDesh]

• fix: Changed empty files sent in addDatasetEntries from [] to { "files" : []} #42 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.