Skip to content

Add createCombo method and example. Fix #20. #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tredondo
Copy link
Contributor

Since @maxicus mentioned he used combos all the time, I've added a createCombo method to simply combo creation.

The example has been tested to work beyond creating the combo. For example, getHistoricalData BID_ASK does obtain correct data for the combo.

@maxicus
Copy link
Owner

maxicus commented Aug 24, 2021

@tredondo good example.
one thing here is that production apps usually already have conIds and other contract details (to take real time data for example) so that method in api class is questionable.

can you make that example standalone please? that's for sure valuable to have it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants